From 55aa15d96d1ff2057cafb644f24aed1182a5cb1d Mon Sep 17 00:00:00 2001
From: Mateusz Kwasniewski <kwasniewski.mateusz@gmail.com>
Date: Wed, 26 Jul 2023 09:39:40 +0200
Subject: [PATCH] test: default strategy stickiness (#4341)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!-- Thanks for creating a PR! To make it easier for reviewers and
everyone else to understand what your changes relate to, please add some
relevant content to the headings below. Feel free to ignore or delete
sections that you don't think are relevant. Thank you! ❤️ -->

## About the changes

Unit tests for the default strategy and fallback strategy

### Important files
<!-- PRs can contain a lot of changes, but not all changes are equally
important. Where should a reviewer start looking to get an overview of
the changes? Are any files particularly important? -->


## Discussion points
<!-- Anything about the PR you'd like to discuss before it gets merged?
Got any questions or doubts? -->
---
 .../EditDefaultStrategy.test.tsx              | 55 +++++++++++++++++++
 .../EditDefaultStrategy.tsx                   |  2 +-
 2 files changed, 56 insertions(+), 1 deletion(-)
 create mode 100644 frontend/src/component/project/Project/ProjectSettings/ProjectDefaultStrategySettings/ProjectEnvironment/ProjectEnvironmentDefaultStrategy/EditDefaultStrategy.test.tsx

diff --git a/frontend/src/component/project/Project/ProjectSettings/ProjectDefaultStrategySettings/ProjectEnvironment/ProjectEnvironmentDefaultStrategy/EditDefaultStrategy.test.tsx b/frontend/src/component/project/Project/ProjectSettings/ProjectDefaultStrategySettings/ProjectEnvironment/ProjectEnvironmentDefaultStrategy/EditDefaultStrategy.test.tsx
new file mode 100644
index 0000000000..bb413c7bb0
--- /dev/null
+++ b/frontend/src/component/project/Project/ProjectSettings/ProjectDefaultStrategySettings/ProjectEnvironment/ProjectEnvironmentDefaultStrategy/EditDefaultStrategy.test.tsx
@@ -0,0 +1,55 @@
+import { screen } from '@testing-library/react';
+import { render } from 'utils/testRenderer';
+import React from 'react';
+import { useDefaultStrategy } from './EditDefaultStrategy';
+import { testServerRoute, testServerSetup } from 'utils/testServer';
+
+const server = testServerSetup();
+
+const RenderStrategy = () => {
+    const { strategy } = useDefaultStrategy('default', 'development');
+
+    return <div>{strategy?.name ?? 'no-default-strategy'}</div>;
+};
+
+const RenderFallbackStrategy = () => {
+    const { defaultStrategyFallback } = useDefaultStrategy(
+        'default',
+        'development'
+    );
+
+    return <div>{defaultStrategyFallback.parameters.stickiness}</div>;
+};
+
+test('should render default strategy from project', async () => {
+    testServerRoute(server, '/api/admin/projects/default', {
+        environments: [
+            {
+                environment: 'development',
+                defaultStrategy: { name: 'my-strategy' },
+            },
+        ],
+    });
+    render(<RenderStrategy />);
+
+    await screen.findByText('my-strategy');
+});
+
+test('should render fallback default strategy with project default stickiness', async () => {
+    testServerRoute(server, '/api/admin/projects/default', {
+        defaultStickiness: 'clientId',
+        environments: [],
+    });
+    render(<RenderFallbackStrategy />);
+
+    await screen.findByText('clientId');
+});
+
+test('should render fallback default strategy with no project default stickiness', async () => {
+    testServerRoute(server, '/api/admin/projects/default', {
+        environments: [],
+    });
+    render(<RenderFallbackStrategy />);
+
+    await screen.findByText('default');
+});
diff --git a/frontend/src/component/project/Project/ProjectSettings/ProjectDefaultStrategySettings/ProjectEnvironment/ProjectEnvironmentDefaultStrategy/EditDefaultStrategy.tsx b/frontend/src/component/project/Project/ProjectSettings/ProjectDefaultStrategySettings/ProjectEnvironment/ProjectEnvironmentDefaultStrategy/EditDefaultStrategy.tsx
index 8899a6efab..99eaea6bed 100644
--- a/frontend/src/component/project/Project/ProjectSettings/ProjectDefaultStrategySettings/ProjectEnvironment/ProjectEnvironmentDefaultStrategy/EditDefaultStrategy.tsx
+++ b/frontend/src/component/project/Project/ProjectSettings/ProjectDefaultStrategySettings/ProjectEnvironment/ProjectEnvironmentDefaultStrategy/EditDefaultStrategy.tsx
@@ -31,7 +31,7 @@ export const useDefaultStrategy = (
         constraints: [],
         parameters: {
             rollout: '100',
-            stickiness: project.defaultStickiness,
+            stickiness: project.defaultStickiness || 'default',
             groupId: '',
         },
     };