Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2024-12-22 19:07:54 +01:00
Code Issues Projects Releases Wiki Activity

chore: list users and groups under each role in projectaccessadded event (#5581)

Browse Source 
## About the changes

Changes the project access added event to list all users and groups
added to each role instead of in root event.
This commit is contained in:
David Leek 2023-12-19 10:16:17 +01:00 committed by GitHub
parent 7800d9d1b4
commit 5603e8683d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/lib/routes/admin-api/events.test.ts
View File

@ -121,11 +121,13 @@ test('should anonymise any PII fields, no matter the depth', async () => {
createdBy: 'some@email.com', createdBy: 'some@email.com',
createdByUserId: TEST_USER_ID, createdByUserId: TEST_USER_ID,
data: { data: {
groups: [ roles: [
{ {
name: 'test', roleId: 1,
project: 'default', groupIds: [1, 2],
users: [{ username: testUsername }], // Doesn't reflect the real data structure for event here, normally a number array.
// Testing PII anonymisation
users: [{ id: 1, username: testUsername }],
}, },
], ],
}, },
@ -138,7 +140,7 @@ test('should anonymise any PII fields, no matter the depth', async () => {
.expect(200); .expect(200);
expect(body.events.length).toBe(1); expect(body.events.length).toBe(1);
expect(body.events[0].data.groups[0].users[0].username).not.toBe( expect(body.events[0].data.roles[0].users[0].username).not.toBe(
testUsername, testUsername,
); );
}); });

18
src/lib/services/project-service.ts
View File

@ -681,9 +681,11 @@ export default class ProjectService {
createdBy, createdBy,
createdByUserId, createdByUserId,
data: { data: {
roleId, roles: {
groups: usersAndGroups.groups.map(({ id }) => id), roleId,
users: usersAndGroups.users.map(({ id }) => id), groupIds: usersAndGroups.groups.map(({ id }) => id),
userIds: usersAndGroups.users.map(({ id }) => id),
},
}, },
}), }),
); );
@ -711,9 +713,13 @@ export default class ProjectService {
createdBy, createdBy,
createdByUserId, createdByUserId,
data: { data: {
roles, roles: roles.map((roleId) => {
groups, return {
users, roleId,
groupIds: groups,
userIds: users,
};
}),
}, },
}), }),
); );