mirror of
				https://github.com/Unleash/unleash.git
				synced 2025-10-27 11:02:16 +01:00 
			
		
		
		
	chore: list users and groups under each role in projectaccessadded event (#5581)
## About the changes Changes the project access added event to list all users and groups added to each role instead of in root event.
This commit is contained in:
		
							parent
							
								
									7800d9d1b4
								
							
						
					
					
						commit
						5603e8683d
					
				@ -121,11 +121,13 @@ test('should anonymise any PII fields, no matter the depth', async () => {
 | 
			
		||||
            createdBy: 'some@email.com',
 | 
			
		||||
            createdByUserId: TEST_USER_ID,
 | 
			
		||||
            data: {
 | 
			
		||||
                groups: [
 | 
			
		||||
                roles: [
 | 
			
		||||
                    {
 | 
			
		||||
                        name: 'test',
 | 
			
		||||
                        project: 'default',
 | 
			
		||||
                        users: [{ username: testUsername }],
 | 
			
		||||
                        roleId: 1,
 | 
			
		||||
                        groupIds: [1, 2],
 | 
			
		||||
                        // Doesn't reflect the real data structure for event here, normally a number array.
 | 
			
		||||
                        // Testing PII anonymisation
 | 
			
		||||
                        users: [{ id: 1, username: testUsername }],
 | 
			
		||||
                    },
 | 
			
		||||
                ],
 | 
			
		||||
            },
 | 
			
		||||
@ -138,7 +140,7 @@ test('should anonymise any PII fields, no matter the depth', async () => {
 | 
			
		||||
        .expect(200);
 | 
			
		||||
 | 
			
		||||
    expect(body.events.length).toBe(1);
 | 
			
		||||
    expect(body.events[0].data.groups[0].users[0].username).not.toBe(
 | 
			
		||||
    expect(body.events[0].data.roles[0].users[0].username).not.toBe(
 | 
			
		||||
        testUsername,
 | 
			
		||||
    );
 | 
			
		||||
});
 | 
			
		||||
 | 
			
		||||
@ -681,9 +681,11 @@ export default class ProjectService {
 | 
			
		||||
                createdBy,
 | 
			
		||||
                createdByUserId,
 | 
			
		||||
                data: {
 | 
			
		||||
                    roleId,
 | 
			
		||||
                    groups: usersAndGroups.groups.map(({ id }) => id),
 | 
			
		||||
                    users: usersAndGroups.users.map(({ id }) => id),
 | 
			
		||||
                    roles: {
 | 
			
		||||
                        roleId,
 | 
			
		||||
                        groupIds: usersAndGroups.groups.map(({ id }) => id),
 | 
			
		||||
                        userIds: usersAndGroups.users.map(({ id }) => id),
 | 
			
		||||
                    },
 | 
			
		||||
                },
 | 
			
		||||
            }),
 | 
			
		||||
        );
 | 
			
		||||
@ -711,9 +713,13 @@ export default class ProjectService {
 | 
			
		||||
                createdBy,
 | 
			
		||||
                createdByUserId,
 | 
			
		||||
                data: {
 | 
			
		||||
                    roles,
 | 
			
		||||
                    groups,
 | 
			
		||||
                    users,
 | 
			
		||||
                    roles: roles.map((roleId) => {
 | 
			
		||||
                        return {
 | 
			
		||||
                            roleId,
 | 
			
		||||
                            groupIds: groups,
 | 
			
		||||
                            userIds: users,
 | 
			
		||||
                        };
 | 
			
		||||
                    }),
 | 
			
		||||
                },
 | 
			
		||||
            }),
 | 
			
		||||
        );
 | 
			
		||||
 | 
			
		||||
		Loading…
	
		Reference in New Issue
	
	Block a user