Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2024-12-22 19:07:54 +01:00
Code Issues Projects Releases Wiki Activity

feat: pre-live should include disabled prod (#7031)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2024-05-10 13:53:01 +02:00 committed by GitHub
parent 60a67d4775
commit 56ae53a4da
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 41 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
frontend/src/component/feature/FeatureView/FeatureOverview/FeatureLifecycle/FeatureLifecycle.tsx
View File

@ -13,6 +13,7 @@ export interface LifecycleFeature {
type: string;
name: string;
lastSeenAt?: string | null;
enabled: boolean;
}>;
}

2
frontend/src/component/feature/FeatureView/FeatureOverview/FeatureLifecycle/FeatureLifecycleTooltip.test.tsx
View File

@ -53,7 +53,7 @@ test('render initial stage', async () => {
await screen.findByText('initial');
await screen.findByText('2 minutes');
await screen.findByText(
"This feature toggle is currently in the initial phase of it's life cycle.",
'This feature flag is currently in the initial phase of its lifecycle.',
);
});

7
frontend/src/component/feature/FeatureView/FeatureOverview/FeatureLifecycle/FeatureLifecycleTooltip.tsx
View File

@ -136,8 +136,8 @@ const InitialStageDescription: FC = () => {
return (
<>
<InfoText>
This feature toggle is currently in the initial phase of it's
life cycle.
This feature flag is currently in the initial phase of its
lifecycle.
</InfoText>
<InfoText>
This means that the flag has been created, but it has not yet
@ -250,8 +250,7 @@ const PreLiveStageDescription: FC = ({ children }) => {
return (
<>
<InfoText>
We've seen the feature flag in the following non-production
environments:
We've seen the feature flag in the following environments:
</InfoText>
{children}

31
frontend/src/component/feature/FeatureView/FeatureOverview/FeatureLifecycle/populateCurrentStage.test.ts
View File

@ -24,13 +24,27 @@ describe('populateCurrentStage', () => {
lifecycle: { stage: 'pre-live', enteredStageAt },
environments: [
{ name: 'test', type: 'development', lastSeenAt: null },
{ name: 'test1', type: 'production', lastSeenAt: '2022-08-01' },
{
name: 'test1',
type: 'production',
lastSeenAt: '2022-08-01',
enabled: true,
},
{ name: 'dev', type: 'development', lastSeenAt: '2022-08-01' },
{
name: 'prod_disabled',
type: 'production',
lastSeenAt: '2022-08-02',
enabled: false,
},
],
} as IFeatureToggle;
const expected = {
name: 'pre-live',
environments: [{ name: 'dev', lastSeenAt: '2022-08-01' }],
environments: [
{ name: 'dev', lastSeenAt: '2022-08-01' },
{ name: 'prod_disabled', lastSeenAt: '2022-08-02' },
],
enteredStageAt,
};
const result = populateCurrentStage(feature);
@ -41,7 +55,18 @@ describe('populateCurrentStage', () => {
const feature = {
lifecycle: { stage: 'live', enteredStageAt },
environments: [
{ name: 'prod', type: 'production', lastSeenAt: '2022-08-01' },
{
name: 'prod',
type: 'production',
lastSeenAt: '2022-08-01',
enabled: true,
},
{
name: 'prod_ignore',
type: 'production',
lastSeenAt: '2022-08-01',
enabled: false,
},
],
} as IFeatureToggle;
const expected = {

12
frontend/src/component/feature/FeatureView/FeatureOverview/FeatureLifecycle/populateCurrentStage.ts
View File

@ -6,9 +6,11 @@ export const populateCurrentStage = (
): LifecycleStage | undefined => {
if (!feature.lifecycle) return undefined;
const getFilteredEnvironments = (condition: (type: string) => boolean) => {
const getFilteredEnvironments = (
condition: (env: { type: string; enabled: boolean }) => boolean,
) => {
return (feature.environments || [])
.filter((env) => condition(env.type) && Boolean(env.lastSeenAt))
.filter((env) => condition(env) && Boolean(env.lastSeenAt))
.map((env) => ({
name: env.name,
lastSeenAt: env.lastSeenAt!,
@ -24,7 +26,9 @@ export const populateCurrentStage = (
return {
name: 'pre-live',
environments: getFilteredEnvironments(
(type) => type !== 'production',
(env) =>
env.type !== 'production' ||
(env.type === 'production' && !env.enabled),
),
enteredStageAt,
};
@ -32,7 +36,7 @@ export const populateCurrentStage = (
return {
name: 'live',
environments: getFilteredEnvironments(
(type) => type === 'production',
(env) => env.type === 'production' && env.enabled,
),
enteredStageAt,
};