Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-08-18 13:48:58 +02:00
Code Issues Projects Releases Wiki Activity

flag dependency change

Browse Source
This commit is contained in:
Thomas Heartman 2025-07-02 13:56:06 +02:00
parent 5dd41c2150
commit 591c971f1c
2 changed files with 74 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

78
frontend/src/component/changeRequest/ChangeRequest/Changes/Change/DependencyChange.tsx
View File

@ -1,11 +1,17 @@
import type { FC, ReactNode } from 'react';
import { styled, Typography } from '@mui/material';
import { Box, styled, Typography } from '@mui/material';
import type {
IChangeRequestAddDependency,
IChangeRequestDeleteDependency,
} from 'component/changeRequest/changeRequest.types';
import { Link } from 'react-router-dom';
import { ChangeItemInfo, ChangeItemWrapper } from './Change.styles';
import {
Added,
ChangeItemInfo,
ChangeItemWrapper,
Deleted,
} from './Change.styles';
import { ChangeItemWrapper as LegacyChangeItemWrapper } from './LegacyStrategyChange.tsx';
const StyledLink = styled(Link)(({ theme }) => ({
maxWidth: '100%',
@ -20,14 +26,62 @@ export const DependencyChange: FC<{
change: IChangeRequestAddDependency | IChangeRequestDeleteDependency;
projectId: string;
onNavigate?: () => void;
}> = ({ actions, change, projectId, onNavigate }) => {
if (change.action === 'addDependency') {
return (
<ChangeItemWrapper>
<ChangeItemInfo>
<Added>Adding dependency</Added>
<StyledLink
to={`/projects/${projectId}/features/${change.payload.feature}`}
onClick={onNavigate}
>
{change.payload.feature}
</StyledLink>
{!change.payload.enabled ? ' (disabled)' : null}
{change.payload.variants?.length
? `(${change.payload.variants?.join(', ')})`
: null}
{actions}
</ChangeItemInfo>
</ChangeItemWrapper>
);
}
if (change.action === 'deleteDependency') {
return (
<ChangeItemWrapper>
<ChangeItemInfo>
<Deleted>Deleting dependencies</Deleted>
{actions}
</ChangeItemInfo>
</ChangeItemWrapper>
);
}
};
const AddDependencyWrapper = styled(Box)(({ theme }) => ({
display: 'flex',
alignItems: 'center',
gap: theme.spacing(1),
}));
/**
* @deprecated use DependencyChange instead; remove with flag crDiffView
*/
export const LegacyDependencyChange: FC<{
actions?: ReactNode;
change: IChangeRequestAddDependency | IChangeRequestDeleteDependency;
projectId: string;
onNavigate?: () => void;
}> = ({ actions, change, projectId, onNavigate }) => {
return (
<>
{change.action === 'addDependency' && (
<>
<ChangeItemWrapper>
<ChangeItemInfo>
<Typography component='span' color={'success.dark'}>
<LegacyChangeItemWrapper>
<AddDependencyWrapper>
<Typography color={'success.dark'}>
+ Adding dependency
</Typography>
<StyledLink
@ -40,25 +94,23 @@ export const DependencyChange: FC<{
{change.payload.variants?.length
? `(${change.payload.variants?.join(', ')})`
: null}
{actions}
</ChangeItemInfo>
</ChangeItemWrapper>
</AddDependencyWrapper>
{actions}
</LegacyChangeItemWrapper>
</>
)}
{change.action === 'deleteDependency' && (
<ChangeItemWrapper>
<ChangeItemInfo>
<AddDependencyWrapper>
<Typography
sx={(theme) => ({
color: theme.palette.error.main,
})}
component='span'
display='inline'
>
- Deleting dependencies
</Typography>
{actions}
</ChangeItemInfo>
</AddDependencyWrapper>
{actions}
</ChangeItemWrapper>
)}
</>

11
frontend/src/component/changeRequest/ChangeRequest/Changes/Change/FeatureChange.tsx
View File

@ -15,7 +15,10 @@ import {
ArchiveFeatureChange,
LegacyArchiveFeatureChange,
} from './ArchiveFeatureChange.tsx';
import { DependencyChange } from './DependencyChange.tsx';
import {
DependencyChange,
LegacyDependencyChange,
} from './DependencyChange.tsx';
import { Link } from 'react-router-dom';
import { LegacyReleasePlanChange } from './LegacyReleasePlanChange.tsx';
import { ReleasePlanChange } from './ReleasePlanChange.tsx';
@ -107,6 +110,10 @@ export const FeatureChange: FC<{
? ArchiveFeatureChange
: LegacyArchiveFeatureChange;
const DependencyChangeComponent = useDiffableChangeComponent
? DependencyChange
: LegacyDependencyChange;
return (
<StyledSingleChangeBox
key={objectId(change)}
@ -166,7 +173,7 @@ export const FeatureChange: FC<{
<ChangeInnerBox>
{(change.action === 'addDependency' ||
change.action === 'deleteDependency') && (
<DependencyChange
<DependencyChangeComponent
actions={actions}
change={change}
projectId={changeRequest.project}