Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-06-14 01:16:17 +02:00
Code Issues Projects Releases Wiki Activity

fix: flickering dialogue (#2558)

Browse Source 
* This PR fixes an issue with flickering states in the change request
dialogue
This commit is contained in:
Fredrik Strand Oseberg 2022-11-29 13:34:30 +01:00 committed by GitHub
parent 87d9466005
commit 5b24b60d31
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/component/changeRequest/ChangeRequestConfirmDialog/ChangeRequestMessages/UpdateEnabledMessage.tsx
View File

@ -12,7 +12,7 @@ export const UpdateEnabledMessage = ({
environment, environment,
}: UpdateEnabledMsg) => ( }: UpdateEnabledMsg) => (
<Typography> <Typography>
<strong>{enabled ? 'Disable' : 'Enable'}</strong> feature toggle{' '} <strong>{enabled ? 'Enable' : 'Disable'}</strong> feature toggle{' '}
<strong>{featureName}</strong> in <strong>{environment}</strong> <strong>{featureName}</strong> in <strong>{environment}</strong>
</Typography> </Typography>
); );

6
frontend/src/hooks/useChangeRequestToggle.ts
View File

@ -31,7 +31,7 @@ export const useChangeRequestToggle = (project: string) => {
); );
const onChangeRequestToggleClose = useCallback(() => { const onChangeRequestToggleClose = useCallback(() => {
setChangeRequestDialogDetails({ isOpen: false }); setChangeRequestDialogDetails(prev => ({ ...prev, isOpen: false }));
}, []); }, []);
const onChangeRequestToggleConfirm = useCallback(async () => { const onChangeRequestToggleConfirm = useCallback(async () => {
@ -48,14 +48,14 @@ export const useChangeRequestToggle = (project: string) => {
} }
); );
refetchChangeRequests(); refetchChangeRequests();
setChangeRequestDialogDetails({ isOpen: false }); setChangeRequestDialogDetails(prev => ({ ...prev, isOpen: false }));
setToastData({ setToastData({
type: 'success', type: 'success',
title: 'Changes added to the draft!', title: 'Changes added to the draft!',
}); });
} catch (error) { } catch (error) {
setToastApiError(formatUnknownError(error)); setToastApiError(formatUnknownError(error));
setChangeRequestDialogDetails({ isOpen: false }); setChangeRequestDialogDetails(prev => ({ ...prev, isOpen: false }));
} }
}, [addChangeRequest]); }, [addChangeRequest]);