Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-20 00:08:02 +01:00
Code Issues Projects Releases Wiki Activity

chore: Add eslint rules and fix strings to pass rules

Browse Source
This commit is contained in:
Clint Checketts 2021-02-22 22:20:10 -07:00
parent 8cd19254c5
commit 5f83fbc43d
11 changed files with 22 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
.eslintrc
View File

@ -9,12 +9,16 @@
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 2019
"ecmaVersion": 2019,
"project": "./tsconfig.json"
},
"plugins": ["prettier","@typescript-eslint"],
"root": true,
"rules": {
"@typescript-eslint/no-var-requires": 0,
"@typescript-eslint/indent": 0,
"@typescript-eslint/naming-convention": 0,
"@typescript-eslint/space-before-function-paren": 0,
"import/no-unresolved": 0,
"class-methods-use-this": [0],
"prettier/prettier": ["error"],
@ -40,7 +44,10 @@
// enable the rule specifically for TypeScript files
"files": ["*.ts", "*.tsx"],
"rules": {
"@typescript-eslint/explicit-module-boundary-types": ["error"]
"@typescript-eslint/explicit-module-boundary-types": ["error"],
"@typescript-eslint/indent": ["error"],
"@typescript-eslint/naming-convention": ["error"],
"@typescript-eslint/space-before-function-paren": ["error"]
}
}
],

2
src/lib/addons/jira-comment.js
View File

@ -86,7 +86,7 @@ class JiraAddon extends Addon {
content: [
{
type: 'text',
text: `To see what happened visit Unleash`,
text: 'To see what happened visit Unleash',
marks: [
{
type: 'link',

2
src/lib/options.js
View File

@ -113,7 +113,7 @@ module.exports = {
if (!options.db.host) {
throw new Error(
`Unleash requires database details to start. See https://unleash.github.io/docs/getting_started`,
'Unleash requires database details to start. See https://unleash.github.io/docs/getting_started',
);
}

2
src/lib/routes/admin-api/metrics.test.js
View File

@ -124,7 +124,7 @@ test('should return applications', t => {
stores.clientApplicationsStore.upsert({ appName });
return request
.get(`/api/admin/metrics/applications/`)
.get('/api/admin/metrics/applications/')
.expect(200)
.expect(res => {
const metrics = res.body;

2
src/lib/routes/admin-api/strategy.test.js
View File

@ -252,7 +252,7 @@ test('reactivating a non-existent strategy yields 404', t => {
.set('Content-Type', 'application/json')
.expect(404);
});
test(`deprecating 'default' strategy will yield 403`, t => {
test("deprecating 'default' strategy will yield 403", t => {
t.plan(0);
const { request, base, perms } = getSetup();
perms.withPermissions(UPDATE_STRATEGY);

4
src/lib/services/state-service.js
View File

@ -63,7 +63,7 @@ class StateService {
: await this.toggleStore.getFeatures();
if (dropBeforeImport) {
this.logger.info(`Dropping existing feature toggles`);
this.logger.info('Dropping existing feature toggles');
await this.toggleStore.dropFeatures();
await this.eventStore.store({
type: DROP_FEATURES,
@ -100,7 +100,7 @@ class StateService {
: await this.strategyStore.getStrategies();
if (dropBeforeImport) {
this.logger.info(`Dropping existing strategies`);
this.logger.info('Dropping existing strategies');
await this.strategyStore.dropStrategies();
await this.eventStore.store({
type: DROP_STRATEGIES,

2
src/migrations/20190123204125-add-variants-to-features.js
View File

@ -11,5 +11,5 @@ exports.up = function(db, callback) {
};
exports.down = function(db, callback) {
db.runSql(`ALTER TABLE features DROP COLUMN "variants";`, callback);
db.runSql('ALTER TABLE features DROP COLUMN "variants";', callback);
};

2
src/migrations/20210119084617-add-addon-table.js
View File

@ -16,5 +16,5 @@ exports.up = function(db, cb) {
};
exports.down = function(db, cb) {
db.runSql(`DROP TABLE addons;`, cb);
db.runSql('DROP TABLE addons;', cb);
};

2
src/migrations/20210121115438-add-deprecated-column-to-strategies.js
View File

@ -10,7 +10,7 @@ exports.up = function(db, cb) {
};
exports.down = function(db, cb) {
db.runSql(`ALTER TABLE strategies DROP COLUMN deprecated`, cb);
db.runSql('ALTER TABLE strategies DROP COLUMN deprecated', cb);
};
exports._meta = {

6
src/test/e2e/api/admin/addon.e2e.test.js
View File

@ -146,7 +146,7 @@ test.serial('should not update with invalid addon configuration', async t => {
};
await request
.put(`/api/admin/addons/1`)
.put('/api/admin/addons/1')
.send(config)
.expect(400);
});
@ -166,7 +166,7 @@ test.serial('should not update unknown addon configuration', async t => {
};
await request
.put(`/api/admin/addons/123123`)
.put('/api/admin/addons/123123')
.send(config)
.expect(404);
});
@ -209,7 +209,7 @@ test.serial('should not get unknown addon configuration', async t => {
t.plan(0);
const request = await setupApp(stores);
await request.get(`/api/admin/addons/445`).expect(404);
await request.get('/api/admin/addons/445').expect(404);
});
test.serial('should not delete unknown addon configuration', async t => {

2
src/test/e2e/api/admin/feature.custom-auth.e2e.test.js
View File

@ -29,7 +29,7 @@ test.serial('should require authenticated user', async t => {
new AuthenticationRequired({
path: '/api/admin/login',
type: 'custom',
message: `You have to identify yourself.`,
message: 'You have to identify yourself.',
}),
)
.end(),