chore: Add eslint rules and fix strings to pass rules

.eslintrc

@@ -9,12 +9,16 @@
     ],
     "parser": "@typescript-eslint/parser",
     "parserOptions": {
-        "ecmaVersion": 2019
+        "ecmaVersion": 2019,
+        "project": "./tsconfig.json"
     },
     "plugins": ["prettier","@typescript-eslint"],
     "root": true,
     "rules": {
         "@typescript-eslint/no-var-requires": 0,
+        "@typescript-eslint/indent": 0,
+        "@typescript-eslint/naming-convention": 0,
+        "@typescript-eslint/space-before-function-paren": 0,
         "import/no-unresolved": 0,
         "class-methods-use-this": [0],
         "prettier/prettier": ["error"],
@@ -40,7 +44,10 @@
             // enable the rule specifically for TypeScript files
             "files": ["*.ts", "*.tsx"],
             "rules": {
-                "@typescript-eslint/explicit-module-boundary-types": ["error"]
+                "@typescript-eslint/explicit-module-boundary-types": ["error"],
+                "@typescript-eslint/indent": ["error"],
+                "@typescript-eslint/naming-convention": ["error"],
+                "@typescript-eslint/space-before-function-paren": ["error"]
             }
         }
     ],

src/lib/addons/jira-comment.js

@@ -86,7 +86,7 @@ class JiraAddon extends Addon {
                         content: [
                             {
                                 type: 'text',
-                                text: `To see what happened visit Unleash`,
+                                text: 'To see what happened visit Unleash',
                                 marks: [
                                     {
                                         type: 'link',

src/lib/options.js

@@ -113,7 +113,7 @@ module.exports = {
 
         if (!options.db.host) {
             throw new Error(
-                `Unleash requires database details to start. See https://unleash.github.io/docs/getting_started`,
+                'Unleash requires database details to start. See https://unleash.github.io/docs/getting_started',
             );
         }
 

src/lib/routes/admin-api/metrics.test.js

@@ -124,7 +124,7 @@ test('should return applications', t => {
     stores.clientApplicationsStore.upsert({ appName });
 
     return request
-        .get(`/api/admin/metrics/applications/`)
+        .get('/api/admin/metrics/applications/')
         .expect(200)
         .expect(res => {
             const metrics = res.body;

src/lib/routes/admin-api/strategy.test.js

@@ -252,7 +252,7 @@ test('reactivating a non-existent strategy yields 404', t => {
         .set('Content-Type', 'application/json')
         .expect(404);
 });
-test(`deprecating 'default' strategy will yield 403`, t => {
+test("deprecating 'default' strategy will yield 403", t => {
     t.plan(0);
     const { request, base, perms } = getSetup();
     perms.withPermissions(UPDATE_STRATEGY);

src/lib/services/state-service.js

@@ -63,7 +63,7 @@ class StateService {
             : await this.toggleStore.getFeatures();
 
         if (dropBeforeImport) {
-            this.logger.info(`Dropping existing feature toggles`);
+            this.logger.info('Dropping existing feature toggles');
             await this.toggleStore.dropFeatures();
             await this.eventStore.store({
                 type: DROP_FEATURES,
@@ -100,7 +100,7 @@ class StateService {
             : await this.strategyStore.getStrategies();
 
         if (dropBeforeImport) {
-            this.logger.info(`Dropping existing strategies`);
+            this.logger.info('Dropping existing strategies');
             await this.strategyStore.dropStrategies();
             await this.eventStore.store({
                 type: DROP_STRATEGIES,

src/migrations/20190123204125-add-variants-to-features.js

@@ -11,5 +11,5 @@ exports.up = function(db, callback) {
 };
 
 exports.down = function(db, callback) {
-    db.runSql(`ALTER TABLE features DROP COLUMN "variants";`, callback);
+    db.runSql('ALTER TABLE features DROP COLUMN "variants";', callback);
 };

src/migrations/20210119084617-add-addon-table.js

@@ -16,5 +16,5 @@ exports.up = function(db, cb) {
 };
 
 exports.down = function(db, cb) {
-    db.runSql(`DROP TABLE addons;`, cb);
+    db.runSql('DROP TABLE addons;', cb);
 };

src/migrations/20210121115438-add-deprecated-column-to-strategies.js

@@ -10,7 +10,7 @@ exports.up = function(db, cb) {
 };
 
 exports.down = function(db, cb) {
-    db.runSql(`ALTER TABLE strategies DROP COLUMN deprecated`, cb);
+    db.runSql('ALTER TABLE strategies DROP COLUMN deprecated', cb);
 };
 
 exports._meta = {

src/test/e2e/api/admin/addon.e2e.test.js

@@ -146,7 +146,7 @@ test.serial('should not update with invalid addon configuration', async t => {
     };
 
     await request
-        .put(`/api/admin/addons/1`)
+        .put('/api/admin/addons/1')
         .send(config)
         .expect(400);
 });
@@ -166,7 +166,7 @@ test.serial('should not update unknown addon configuration', async t => {
     };
 
     await request
-        .put(`/api/admin/addons/123123`)
+        .put('/api/admin/addons/123123')
         .send(config)
         .expect(404);
 });
@@ -209,7 +209,7 @@ test.serial('should not get unknown addon configuration', async t => {
     t.plan(0);
     const request = await setupApp(stores);
 
-    await request.get(`/api/admin/addons/445`).expect(404);
+    await request.get('/api/admin/addons/445').expect(404);
 });
 
 test.serial('should not delete unknown addon configuration', async t => {

src/test/e2e/api/admin/feature.custom-auth.e2e.test.js

@@ -29,7 +29,7 @@ test.serial('should require authenticated user', async t => {
                     new AuthenticationRequired({
                         path: '/api/admin/login',
                         type: 'custom',
-                        message: `You have to identify yourself.`,
+                        message: 'You have to identify yourself.',
                     }),
                 )
                 .end(),