From 61e297dd22965736c8d2a2aa383a341ac7251f8f Mon Sep 17 00:00:00 2001 From: Mateusz Kwasniewski Date: Wed, 13 Nov 2024 12:10:53 +0100 Subject: [PATCH] fix: password auth metrics (#8735) --- src/lib/features/instance-stats/instance-stats-service.ts | 5 ++++- src/lib/metrics.ts | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/lib/features/instance-stats/instance-stats-service.ts b/src/lib/features/instance-stats/instance-stats-service.ts index 04d845cc56..9b331bd9d8 100644 --- a/src/lib/features/instance-stats/instance-stats-service.ts +++ b/src/lib/features/instance-stats/instance-stats-service.ts @@ -224,7 +224,10 @@ export class InstanceStatsService { 'unleash.auth.simple', ); - return settings?.disabled !== false; + return ( + typeof settings?.disabled === 'undefined' || + settings.disabled === false + ); } async hasSCIM(): Promise { diff --git a/src/lib/metrics.ts b/src/lib/metrics.ts index 003c69e5d3..49108effa8 100644 --- a/src/lib/metrics.ts +++ b/src/lib/metrics.ts @@ -408,7 +408,7 @@ export function registerPrometheusMetrics( }); dbMetrics.registerGaugeDbMetric({ - name: 'password_auth', + name: 'password_auth_enabled', help: 'Whether password auth is enabled', query: () => instanceStatsService.hasPasswordAuth(), map: (result) => ({ value: result ? 1 : 0 }),