From 62dbf8d12ff4a3a5e85094c7e5e9a71ccfa8a324 Mon Sep 17 00:00:00 2001
From: Jaanus Sellin <sellinjaanus@gmail.com>
Date: Tue, 21 Nov 2023 14:44:41 +0200
Subject: [PATCH] fix: last seen is now using last seen values from new table
 (#5380)

In short the issue is that after our last seen improvements, we did not
update where we are getting last_seen field. It was still using features
table, which is not the source of last seen anymore.
---
 .../feature-toggle-strategies-store.ts        | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

diff --git a/src/lib/features/feature-toggle/feature-toggle-strategies-store.ts b/src/lib/features/feature-toggle/feature-toggle-strategies-store.ts
index c3a5674233..34fe4aac50 100644
--- a/src/lib/features/feature-toggle/feature-toggle-strategies-store.ts
+++ b/src/lib/features/feature-toggle/feature-toggle-strategies-store.ts
@@ -386,7 +386,6 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
                 acc.description = r.description;
                 acc.project = r.project;
                 acc.stale = r.stale;
-                acc.lastSeenAt = r.last_seen_at;
 
                 acc.createdAt = r.created_at;
                 acc.type = r.type;
@@ -396,6 +395,14 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
                         lastSeenAt: r.env_last_seen_at,
                     };
                 }
+
+                if (
+                    acc.lastSeenAt === undefined ||
+                    new Date(r.env_last_seen_at) > new Date(acc.lastSeenAt)
+                ) {
+                    acc.lastSeenAt = r.env_last_seen_at;
+                }
+
                 const env = acc.environments[r.environment];
 
                 const variants = r.variants || [];
@@ -650,7 +657,6 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
                     'features.description as description',
                     'features.type as type',
                     'features.created_at as created_at',
-                    'features.last_seen_at as last_seen_at',
                     'features.stale as stale',
                     'features.impression_data as impression_data',
                     'feature_environments.enabled as enabled',
@@ -808,7 +814,6 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
             'features.description as description',
             'features.type as type',
             'features.created_at as created_at',
-            'features.last_seen_at as last_seen_at',
             'features.stale as stale',
             'features.impression_data as impression_data',
             'feature_environments.enabled as enabled',
@@ -890,7 +895,6 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
                     favorite: row.favorite,
                     name: row.feature_name,
                     createdAt: row.created_at,
-                    lastSeenAt: row.last_seen_at,
                     stale: row.stale,
                     impressionData: row.impression_data,
                     environments: [FeatureStrategiesStore.getEnvironment(row)],
@@ -900,6 +904,13 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
                     this.addTag(acc[row.feature_name], row);
                 }
             }
+            const featureRow = acc[row.feature_name];
+            if (
+                featureRow.lastSeenAt === undefined ||
+                new Date(row.env_last_seen_at) > new Date(featureRow.lastSeenAt)
+            ) {
+                featureRow.lastSeenAt = row.env_last_seen_at;
+            }
             return acc;
         }, {});
     }