Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-07-26 13:48:33 +02:00
Code Issues Projects Releases Wiki Activity

chore: print out 10 unknown flag names (#10062)

Browse Source 
- Move logs, and replace a debug log with just the info log while adding
appName to it
- Print out at most 10 invalid flag names
This commit is contained in:
Gastón Fournier 2025-05-30 12:24:41 +02:00 committed by GitHub
parent 898073878b
commit 63bf01d211
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/lib/features/metrics/client-metrics/metrics-service-v2.ts
View File

@ -132,12 +132,6 @@ export default class ClientMetricsServiceV2 {
existingFlags.includes(name),
);
if (existingNames.length !== toggleNames.length) {
this.logger.info(
`Filtered out ${toggleNames.length - existingNames.length} toggles with non-existing names`,
);
}
if (this.flagResolver.isEnabled('reportUnknownFlags')) {
try {
const nonExistingNames = toggleNames.filter(
@ -209,8 +203,10 @@ export default class ClientMetricsServiceV2 {
const { validatedToggleNames, unknownToggleNames } =
await this.filterExistingToggleNames(toggleNames);
this.logger.debug(
`Got ${toggleNames.length} (${validatedToggleNames.length} valid) metrics from ${clientIp}`,
const invalidToggleNames =
toggleNames.length - validatedToggleNames.length;
this.logger.info(
`Got ${toggleNames.length} (${invalidToggleNames > 0 ? `${invalidToggleNames} invalid ones` : 'all valid'}) metrics from ${value.appName}`,
);
if (data.sdkVersion) {
@ -235,6 +231,12 @@ export default class ClientMetricsServiceV2 {
appName: value.appName,
seenAt: value.bucket.stop,
}));
this.logger.info(
`Registering ${unknownFlags.length} unknown flags from ${value.appName}, i.e.: ${unknownFlags
.slice(0, 10)
.map((f) => f.name)
.join(', ')}`,
);
this.unknownFlagsService.register(unknownFlags);
}