Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-19 00:15:43 +01:00
Code Issues Projects Releases Wiki Activity

fix: move /api/admin/features

Browse Source
This commit is contained in:
Fredrik Oseberg 2022-01-14 11:09:16 +01:00
parent 8571250b3a
commit 65cdd9f3a9
2 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/routes/admin-api/feature.ts
View File

@ -41,7 +41,6 @@ class FeatureController extends Controller {
this.service = featureToggleServiceV2; this.service = featureToggleServiceV2;
if (!config.disableLegacyFeaturesApi) { if (!config.disableLegacyFeaturesApi) {
this.get('/', this.getAllToggles);
this.post('/', this.createToggle, CREATE_FEATURE); this.post('/', this.createToggle, CREATE_FEATURE);
this.get('/:featureName', this.getToggle); this.get('/:featureName', this.getToggle);
this.put('/:featureName', this.updateToggle, UPDATE_FEATURE); this.put('/:featureName', this.updateToggle, UPDATE_FEATURE);
@ -58,6 +57,7 @@ class FeatureController extends Controller {
this.post('/:featureName/stale/off', this.staleOff, UPDATE_FEATURE); this.post('/:featureName/stale/off', this.staleOff, UPDATE_FEATURE);
} }
this.get('/', this.getAllToggles);
this.post('/validate', this.validate, NONE); this.post('/validate', this.validate, NONE);
this.get('/:featureName/tags', this.listTags); this.get('/:featureName/tags', this.listTags);
this.post('/:featureName/tags', this.addTag, UPDATE_FEATURE); this.post('/:featureName/tags', this.addTag, UPDATE_FEATURE);

17
src/test/e2e/api/admin/feature.e2e.test.ts
View File

@ -693,10 +693,6 @@ test('should not hit endpoints if disable configuration is set', async () => {
}, },
); );
await appWithDisabledLegacyFeatures.request
.get('/api/admin/features')
.expect(404);
await appWithDisabledLegacyFeatures.request await appWithDisabledLegacyFeatures.request
.get('/api/admin/features/featureX') .get('/api/admin/features/featureX')
.expect('Content-Type', /json/) .expect('Content-Type', /json/)
@ -745,3 +741,16 @@ test('should hit validate and tags endpoint if legacy api is disabled', async ()
.send({ name: 'validateThis' }) .send({ name: 'validateThis' })
.expect(200); .expect(200);
}); });
test('should have access to the get all features endpoint even if api is disabled', async () => {
const appWithDisabledLegacyFeatures = await setupAppWithCustomConfig(
db.stores,
{
disableLegacyFeaturesApi: true,
},
);
await appWithDisabledLegacyFeatures.request
.get('/api/admin/features')
.expect(200);
});