Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

chore: patch scim tests to allow for deleting a scim user

Browse Source
This commit is contained in:
Simon Hornby 2025-02-03 12:02:46 +02:00
parent 5c5d48db1e
commit 666b64e288
No known key found for this signature in database
GPG Key ID: 57BE3E58BA999B19
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/test/e2e/api/admin/user-admin.scim.e2e.test.ts
View File

@ -12,6 +12,7 @@ let app: IUnleashTest;
let scimUserId: number; let scimUserId: number;
let regularUserId: number; let regularUserId: number;
let scimDeletableUser: number;
const scimUser = { const scimUser = {
email: 'scim-user@test.com', email: 'scim-user@test.com',
@ -24,6 +25,12 @@ const regularUser = {
name: 'Regular User', name: 'Regular User',
}; };
const scimUserToBeDeleted = {
email: 'scim-victim@test.com',
name: 'SCIM Victim',
scim_id: 'some-other-random-scim-id',
};
const scimGuardErrorMessage = const scimGuardErrorMessage =
'This user is managed by your SCIM provider and cannot be changed manually'; 'This user is managed by your SCIM provider and cannot be changed manually';
@ -50,6 +57,13 @@ beforeAll(async () => {
regularUserId = ( regularUserId = (
await db.rawDatabase('users').insert(regularUser).returning('id') await db.rawDatabase('users').insert(regularUser).returning('id')
)[0].id; )[0].id;
scimDeletableUser = (
await db
.rawDatabase('users')
.insert(scimUserToBeDeleted)
.returning('id')
)[0].id;
}); });
afterAll(async () => { afterAll(async () => {
@ -86,12 +100,10 @@ test('should prevent editing a SCIM user', async () => {
expect(body.details[0].message).toBe(scimGuardErrorMessage); expect(body.details[0].message).toBe(scimGuardErrorMessage);
}); });
test('should prevent deleting a SCIM user', async () => { test('should not prevent deleting a SCIM user', async () => {
const { body } = await app.request await app.request
.delete(`/api/admin/user-admin/${scimUserId}`) .delete(`/api/admin/user-admin/${scimDeletableUser}`)
.expect(403); .expect(200);
expect(body.details[0].message).toBe(scimGuardErrorMessage);
}); });
test('should prevent changing password for a SCIM user', async () => { test('should prevent changing password for a SCIM user', async () => {