From 670b97dede04bf021fb4264120682cde9fa4f0cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ivar=20Conradi=20=C3=98sthus?= Date: Wed, 9 Nov 2022 22:43:13 +0100 Subject: [PATCH] fix: set suggested min value to 0 (#2363) This PR does one thing, it sets the y-axis to start at "0" when showing request counts over time. ![image](https://user-images.githubusercontent.com/158948/200946347-b3e803c6-6ace-4ecc-b5cf-aa92a5505331.png) fixes #2107 --- .../FeatureMetrics/FeatureMetricsChart/createChartOptions.ts | 2 ++ .../FeatureMetrics/FeatureMetricsHours/FeatureMetricsHours.tsx | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/frontend/src/component/feature/FeatureView/FeatureMetrics/FeatureMetricsChart/createChartOptions.ts b/frontend/src/component/feature/FeatureView/FeatureMetrics/FeatureMetricsChart/createChartOptions.ts index abc1e00a4c..2b4b57c41b 100644 --- a/frontend/src/component/feature/FeatureView/FeatureMetrics/FeatureMetricsChart/createChartOptions.ts +++ b/frontend/src/component/feature/FeatureView/FeatureMetrics/FeatureMetricsChart/createChartOptions.ts @@ -65,6 +65,8 @@ export const createChartOptions = ( display: true, text: 'Number of requests', }, + // min: 0, + suggestedMin: 0, ticks: { precision: 0 }, }, x: { diff --git a/frontend/src/component/feature/FeatureView/FeatureMetrics/FeatureMetricsHours/FeatureMetricsHours.tsx b/frontend/src/component/feature/FeatureView/FeatureMetrics/FeatureMetricsHours/FeatureMetricsHours.tsx index 36ae7dbd66..0d650ae4d3 100644 --- a/frontend/src/component/feature/FeatureView/FeatureMetrics/FeatureMetricsHours/FeatureMetricsHours.tsx +++ b/frontend/src/component/feature/FeatureView/FeatureMetrics/FeatureMetricsHours/FeatureMetricsHours.tsx @@ -33,7 +33,7 @@ export const FeatureMetricsHours = ({ const parseFeatureMetricsHour = (value: unknown) => { switch (value) { case '1': - return 1; + return 2; case '24': return 24; default: