Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

feat: prevent revive flag/flags in archived project (#7826)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2024-08-12 13:29:24 +02:00 committed by GitHub
parent 624c6ce9c3
commit 67fa28f05a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/lib/features/feature-toggle/feature-toggle-service.ts
View File

@ -1235,6 +1235,18 @@ class FeatureToggleService {
}
}
private async validateActiveProject(projectId: string) {
if (this.flagResolver.isEnabled('archiveProjects')) {
const hasActiveProject =
await this.projectStore.hasActiveProject(projectId);
if (!hasActiveProject) {
throw new NotFoundError(
`Active project with id ${projectId} does not exist`,
);
}
}
}
async createFeatureToggle(
projectId: string,
value: FeatureToggleDTO,
@ -2058,6 +2070,7 @@ class FeatureToggleService {
projectId: string,
auditUser: IAuditUser,
): Promise<void> {
await this.validateActiveProject(projectId);
await this.validateFeaturesContext(featureNames, projectId);
const features =
@ -2091,6 +2104,11 @@ class FeatureToggleService {
featureName: string,
auditUser: IAuditUser,
): Promise<void> {
const feature = await this.featureToggleStore.get(featureName);
if (!feature) {
throw new NotFoundError(`Feature ${featureName} does not exist`);
}
await this.validateActiveProject(feature.project);
const toggle = await this.featureToggleStore.revive(featureName);
await this.featureToggleStore.disableAllEnvironmentsForFeatures([
featureName,

37
src/lib/features/feature-toggle/tests/feature-toggle-service.e2e.test.ts
View File

@ -773,3 +773,40 @@ test('Should not allow to add flags to archived projects', async () => {
),
);
});
test('Should not allow to revive flags to archived projects', async () => {
const project = await stores.projectStore.create({
id: 'archivedProjectWithFlag',
name: 'archivedProjectWithFlag',
});
const flag = await service.createFeatureToggle(
project.id,
{
name: 'archiveFlag',
},
TEST_AUDIT_USER,
);
await service.archiveToggle(
flag.name,
{ email: 'test@example.com' } as User,
TEST_AUDIT_USER,
);
await stores.projectStore.archive(project.id);
await expect(
service.reviveFeature(flag.name, TEST_AUDIT_USER),
).rejects.toEqual(
new NotFoundError(
`Active project with id archivedProjectWithFlag does not exist`,
),
);
await expect(
service.reviveFeatures([flag.name], project.id, TEST_AUDIT_USER),
).rejects.toEqual(
new NotFoundError(
`Active project with id archivedProjectWithFlag does not exist`,
),
);
});