1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-14 00:19:16 +01:00

[Gitar] Cleaning up stale flag: trackLifecycleMetrics with value false (#8833)

[![Gitar](https://raw.githubusercontent.com/gitarcode/.github/main/assets/gitar-banner.svg)](https://gitar.ai)
This automated PR permanently removes the `trackLifecycleMetrics`
feature flag.
  
  ---
This automated PR was generated by [Gitar](https://gitar.ai). View
[docs](https://gitar.ai/docs).

Co-authored-by: Gitar <noreply@gitar.ai>
This commit is contained in:
gitar-bot[bot] 2024-11-22 11:54:28 +02:00 committed by GitHub
parent 0e7b675ede
commit 6844984610
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 0 additions and 23 deletions

View File

@ -132,21 +132,8 @@ export class FeatureLifecycleService {
} }
private recordStagesEntered(newlyEnteredStages: NewStage[]) { private recordStagesEntered(newlyEnteredStages: NewStage[]) {
if (
this.flagResolver.isEnabled('trackLifecycleMetrics') &&
newlyEnteredStages.length > 0
) {
this.logger.info(
`recordStagesEntered parameter ${JSON.stringify(newlyEnteredStages)}`,
);
}
newlyEnteredStages.forEach(({ stage, feature }) => { newlyEnteredStages.forEach(({ stage, feature }) => {
this.eventBus.emit(STAGE_ENTERED, { stage, feature }); this.eventBus.emit(STAGE_ENTERED, { stage, feature });
if (this.flagResolver.isEnabled('trackLifecycleMetrics')) {
this.logger.info(
`STAGE_ENTERED emitted ${JSON.stringify({ stage, feature })}`,
);
}
}); });
} }

View File

@ -672,11 +672,6 @@ export function registerPrometheusMetrics(
eventBus.on( eventBus.on(
events.STAGE_ENTERED, events.STAGE_ENTERED,
(entered: { stage: string; feature: string }) => { (entered: { stage: string; feature: string }) => {
if (flagResolver.isEnabled('trackLifecycleMetrics')) {
logger.info(
`STAGE_ENTERED listened ${JSON.stringify(entered)}`,
);
}
featureLifecycleStageEnteredCounter.increment({ featureLifecycleStageEnteredCounter.increment({
stage: entered.stage, stage: entered.stage,
}); });

View File

@ -49,7 +49,6 @@ export type IFlagKey =
| 'removeUnsafeInlineStyleSrc' | 'removeUnsafeInlineStyleSrc'
| 'onboardingUI' | 'onboardingUI'
| 'projectRoleAssignment' | 'projectRoleAssignment'
| 'trackLifecycleMetrics'
| 'purchaseAdditionalEnvironments' | 'purchaseAdditionalEnvironments'
| 'originMiddlewareRequestLogging' | 'originMiddlewareRequestLogging'
| 'unleashAI' | 'unleashAI'
@ -246,10 +245,6 @@ const flags: IFlags = {
process.env.UNLEASH_EXPERIMENTAL_PROJECT_ROLE_ASSIGNMENT, process.env.UNLEASH_EXPERIMENTAL_PROJECT_ROLE_ASSIGNMENT,
false, false,
), ),
trackLifecycleMetrics: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_TRACK_LIFECYCLE_METRICS,
false,
),
purchaseAdditionalEnvironments: parseEnvVarBoolean( purchaseAdditionalEnvironments: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_PURCHASE_ADDITIONAL_ENVIRONMENTS, process.env.UNLEASH_EXPERIMENTAL_PURCHASE_ADDITIONAL_ENVIRONMENTS,
false, false,