Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-10 17:53:36 +02:00
Code Issues Projects Releases Wiki Activity

fix: Return all toggles when env var is set and flag is on

Browse Source 
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
This commit is contained in:
andreas-unleash 2023-03-02 16:44:08 +02:00
parent 456eb04591
commit 689b46c517
No known key found for this signature in database
GPG Key ID: DB82A1577B38F66B
3 changed files with 94 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lib/routes/proxy-api/index.ts
View File

@ -20,6 +20,7 @@ import {
import { Context } from 'unleash-client';
import { enrichContextWithIp } from '../../proxy';
import { corsOriginMiddleware } from '../../middleware';
import * as process from 'process';
interface ApiUserRequest<
PARAM = any,
@ -145,7 +146,10 @@ export default class ProxyController extends Controller {
res: Response<ProxyFeaturesSchema>,
) {
let toggles;
if (this.flagResolver.isEnabled('proxyReturnAllToggles')) {
if (
this.flagResolver.isEnabled('proxyReturnAllToggles') &&
Boolean(process.env.RETURN_ALL_TOGGLES)
) {
toggles = await this.services.proxyService.getAllProxyFeatures(
req.user,
ProxyController.createContext(req),

2
src/lib/services/proxy-service.ts
View File

@ -86,7 +86,7 @@ export class ProxyService {
return definitions.map((feature) => ({
name: feature.name,
enabled: Boolean(feature.enabled),
enabled: Boolean(client.isEnabled(feature.name)),
variant: client.forceGetVariant(feature.name, context),
impressionData: Boolean(feature.impressionData),
}));

91
src/test/e2e/api/proxy/proxy.e2e.test.ts
View File

@ -14,6 +14,7 @@ import {
IStrategyConfig,
} from '../../../../lib/types';
import { ProxyRepository } from '../../../../lib/proxy';
import * as process from 'process';
let app: IUnleashTest;
let db: ITestDb;
@ -935,6 +936,7 @@ test('Should not recursively set off timers on events', async () => {
test('should return all features when specified', async () => {
app.config.experimental.flags.proxyReturnAllToggles = true;
process.env.RETURN_ALL_TOGGLES = 'true';
const frontendToken = await createApiToken(ApiTokenType.FRONTEND);
await createFeatureToggle({
name: 'enabledFeature1',
@ -944,12 +946,32 @@ test('should return all features when specified', async () => {
await createFeatureToggle({
name: 'enabledFeature2',
enabled: true,
strategies: [{ name: 'default', constraints: [], parameters: {} }],
strategies: [
{
name: 'flexibleRollout',
constraints: [],
parameters: {
rollout: '100',
stickiness: 'default',
groupId: 'some-new',
},
},
],
});
await createFeatureToggle({
name: 'disabledFeature',
enabled: false,
strategies: [{ name: 'default', constraints: [], parameters: {} }],
enabled: true,
strategies: [
{
name: 'flexibleRollout',
constraints: [],
parameters: {
rollout: '0',
stickiness: 'default',
groupId: 'some-new',
},
},
],
});
await app.request
.get('/api/frontend')
@ -982,6 +1004,69 @@ test('should return all features when specified', async () => {
});
});
test('should return all features when env var is set only', async () => {
app.config.experimental.flags.proxyReturnAllToggles = true;
const frontendToken = await createApiToken(ApiTokenType.FRONTEND);
await createFeatureToggle({
name: 'enabledFeature1',
enabled: true,
strategies: [{ name: 'default', constraints: [], parameters: {} }],
});
await createFeatureToggle({
name: 'enabledFeature2',
enabled: true,
strategies: [
{
name: 'flexibleRollout',
constraints: [],
parameters: {
rollout: '100',
stickiness: 'default',
groupId: 'some-new',
},
},
],
});
await createFeatureToggle({
name: 'disabledFeature',
enabled: true,
strategies: [
{
name: 'flexibleRollout',
constraints: [],
parameters: {
rollout: '0',
stickiness: 'default',
groupId: 'some-new',
},
},
],
});
await app.request
.get('/api/frontend')
.set('Authorization', frontendToken.secret)
.expect('Content-Type', /json/)
.expect(200)
.expect((res) => {
expect(res.body).toEqual({
toggles: [
{
name: 'enabledFeature1',
enabled: true,
impressionData: false,
variant: { enabled: false, name: 'disabled' },
},
{
name: 'enabledFeature2',
enabled: true,
impressionData: false,
variant: { enabled: false, name: 'disabled' },
},
],
});
});
});
test('should return maxAge header on options call', async () => {
await app.request
.options('/api/frontend')