From 68bfde58f765b3d9bb0cce7d908828c8ebbbf941 Mon Sep 17 00:00:00 2001 From: olav Date: Thu, 23 Jun 2022 12:05:06 +0200 Subject: [PATCH] fix: use correct docs API URL for feature strategy create/update (#1116) * fix: use correct URL for update feature strategy * fix: use correct URL for create feature strategy --- .../FeatureStrategyCreate.test.tsx | 20 +++++++++++++++++++ .../FeatureStrategyCreate.tsx | 4 ++-- .../FeatureStrategyEdit.test.tsx | 20 +++++++++++++++++++ .../FeatureStrategyEdit.tsx | 4 ++-- 4 files changed, 44 insertions(+), 4 deletions(-) create mode 100644 frontend/src/component/feature/FeatureStrategy/FeatureStrategyCreate/FeatureStrategyCreate.test.tsx create mode 100644 frontend/src/component/feature/FeatureStrategy/FeatureStrategyEdit/FeatureStrategyEdit.test.tsx diff --git a/frontend/src/component/feature/FeatureStrategy/FeatureStrategyCreate/FeatureStrategyCreate.test.tsx b/frontend/src/component/feature/FeatureStrategy/FeatureStrategyCreate/FeatureStrategyCreate.test.tsx new file mode 100644 index 0000000000..42458dc599 --- /dev/null +++ b/frontend/src/component/feature/FeatureStrategy/FeatureStrategyCreate/FeatureStrategyCreate.test.tsx @@ -0,0 +1,20 @@ +import { formatAddStrategyApiCode } from 'component/feature/FeatureStrategy/FeatureStrategyCreate/FeatureStrategyCreate'; + +test('formatAddStrategyApiCode', () => { + expect( + formatAddStrategyApiCode( + 'projectId', + 'featureId', + 'environmentId', + { id: 'strategyId' }, + 'unleashUrl' + ) + ).toMatchInlineSnapshot(` + "curl --location --request POST 'unleashUrl/api/admin/projects/projectId/features/featureId/environments/environmentId/strategies' \\\\ + --header 'Authorization: INSERT_API_KEY' \\\\ + --header 'Content-Type: application/json' \\\\ + --data-raw '{ + \\"id\\": \\"strategyId\\" + }'" + `); +}); diff --git a/frontend/src/component/feature/FeatureStrategy/FeatureStrategyCreate/FeatureStrategyCreate.tsx b/frontend/src/component/feature/FeatureStrategy/FeatureStrategyCreate/FeatureStrategyCreate.tsx index 272fda8be6..15340a0859 100644 --- a/frontend/src/component/feature/FeatureStrategy/FeatureStrategyCreate/FeatureStrategyCreate.tsx +++ b/frontend/src/component/feature/FeatureStrategy/FeatureStrategyCreate/FeatureStrategyCreate.tsx @@ -121,7 +121,7 @@ export const formatCreateStrategyPath = ( return `/projects/${projectId}/features/${featureId}/strategies/create?${params}`; }; -const formatAddStrategyApiCode = ( +export const formatAddStrategyApiCode = ( projectId: string, featureId: string, environmentId: string, @@ -132,7 +132,7 @@ const formatAddStrategyApiCode = ( return ''; } - const url = `${unleashUrl}/api/admin/projects/${projectId}/features/${featureId}/${environmentId}/development/strategies`; + const url = `${unleashUrl}/api/admin/projects/${projectId}/features/${featureId}/environments/${environmentId}/strategies`; const payload = JSON.stringify(strategy, undefined, 2); return `curl --location --request POST '${url}' \\ diff --git a/frontend/src/component/feature/FeatureStrategy/FeatureStrategyEdit/FeatureStrategyEdit.test.tsx b/frontend/src/component/feature/FeatureStrategy/FeatureStrategyEdit/FeatureStrategyEdit.test.tsx new file mode 100644 index 0000000000..6104e7a15d --- /dev/null +++ b/frontend/src/component/feature/FeatureStrategy/FeatureStrategyEdit/FeatureStrategyEdit.test.tsx @@ -0,0 +1,20 @@ +import { formatUpdateStrategyApiCode } from 'component/feature/FeatureStrategy/FeatureStrategyEdit/FeatureStrategyEdit'; + +test('formatUpdateStrategyApiCode', () => { + expect( + formatUpdateStrategyApiCode( + 'projectId', + 'featureId', + 'environmentId', + { id: 'strategyId' }, + 'unleashUrl' + ) + ).toMatchInlineSnapshot(` + "curl --location --request PUT 'unleashUrl/api/admin/projects/projectId/features/featureId/environments/environmentId/strategies/strategyId' \\\\ + --header 'Authorization: INSERT_API_KEY' \\\\ + --header 'Content-Type: application/json' \\\\ + --data-raw '{ + \\"id\\": \\"strategyId\\" + }'" + `); +}); diff --git a/frontend/src/component/feature/FeatureStrategy/FeatureStrategyEdit/FeatureStrategyEdit.tsx b/frontend/src/component/feature/FeatureStrategy/FeatureStrategyEdit/FeatureStrategyEdit.tsx index 6c72136a8c..f684c6eb7c 100644 --- a/frontend/src/component/feature/FeatureStrategy/FeatureStrategyEdit/FeatureStrategyEdit.tsx +++ b/frontend/src/component/feature/FeatureStrategy/FeatureStrategyEdit/FeatureStrategyEdit.tsx @@ -148,7 +148,7 @@ export const formatEditStrategyPath = ( return `/projects/${projectId}/features/${featureId}/strategies/edit?${params}`; }; -const formatUpdateStrategyApiCode = ( +export const formatUpdateStrategyApiCode = ( projectId: string, featureId: string, environmentId: string, @@ -159,7 +159,7 @@ const formatUpdateStrategyApiCode = ( return ''; } - const url = `${unleashUrl}/api/admin/projects/${projectId}/features/${featureId}/${environmentId}/development/strategies/${strategy.id}`; + const url = `${unleashUrl}/api/admin/projects/${projectId}/features/${featureId}/environments/${environmentId}/strategies/${strategy.id}`; const payload = JSON.stringify(strategy, undefined, 2); return `curl --location --request PUT '${url}' \\