1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-09 00:18:00 +01:00

feat: update the user-specific topic (#3608)

https://linear.app/unleash/issue/2-961/update-demo-guide-steps-to-not-include-a-userids-strategy

Updates the user-specific toggle topic to use a standard strategy with a
constraint instead (deprecate UserID strategy).

Relates to [roadmap](https://github.com/orgs/Unleash/projects/10) item:
#3537

<img width="1282" alt="image"
src="https://user-images.githubusercontent.com/14320932/233987506-380d89e3-bd5d-461d-a5dc-89e54ad21d88.png">
This commit is contained in:
Nuno Góis 2023-04-24 13:02:06 +01:00 committed by GitHub
parent 0e84b973dd
commit 697fb6aab5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 74 additions and 4 deletions

View File

@ -63,6 +63,7 @@ export const ConstraintAccordionEditBody: React.FC<
onClick={onSubmit} onClick={onSubmit}
variant="contained" variant="contained"
color="primary" color="primary"
data-testid="CONSTRAINT_SAVE_BUTTON"
> >
Save Save
</StyledLeftButton> </StyledLeftButton>

View File

@ -106,6 +106,7 @@ export const FreeTextInput = ({
className={styles.input} className={styles.input}
error={Boolean(error)} error={Boolean(error)}
errorText={error} errorText={error}
data-testid="CONSTRAINT_VALUES_INPUT"
/> />
</div> </div>
<Button <Button
@ -113,6 +114,7 @@ export const FreeTextInput = ({
variant="outlined" variant="outlined"
color="primary" color="primary"
onClick={() => addValues()} onClick={() => addValues()}
data-testid="CONSTRAINT_VALUES_ADD_BUTTON"
> >
Add values Add values
</Button> </Button>

View File

@ -190,6 +190,7 @@ export const ConstraintAccordionList = forwardRef<
onClick={onAdd} onClick={onAdd}
variant="outlined" variant="outlined"
color="primary" color="primary"
data-testid="ADD_CONSTRAINT_BUTTON"
> >
Add constraint Add constraint
</Button> </Button>

View File

@ -182,7 +182,7 @@ export const DemoSteps = ({
waitForLoad(step, tries + 1); waitForLoad(step, tries + 1);
} }
} }
}, 200); }, 300);
}; };
useEffect(() => { useEffect(() => {

View File

@ -127,10 +127,10 @@ export const TOPICS: ITutorialTopic[] = [
), ),
}, },
{ {
target: 'a[href="/projects/default/features/demoApp.step2/strategies/create?environmentId=default&strategyName=userWithId"]', target: 'a[href="/projects/default/features/demoApp.step2/strategies/create?environmentId=default&strategyName=default"]',
content: ( content: (
<Description> <Description>
Select the <Badge as="span">UserIDs</Badge> strategy Select the <Badge as="span">Standard</Badge> strategy
type. type.
</Description> </Description>
), ),
@ -138,7 +138,62 @@ export const TOPICS: ITutorialTopic[] = [
backCloseModal: true, backCloseModal: true,
}, },
{ {
target: '#input-add-items', target: 'button[data-testid="ADD_CONSTRAINT_BUTTON"]',
content: (
<>
<Description>
<a
href="https://docs.getunleash.io/reference/strategy-constraints"
target="_blank"
>
Strategy constraints
</a>{' '}
are conditions that must be satisfied for an{' '}
<a
href="https://docs.getunleash.io/reference/activation-strategies"
target="_blank"
>
activation strategy
</a>{' '}
to be evaluated for a feature toggle.
</Description>
<Description sx={{ mt: 1 }}>
Click this button to add a constraint.
</Description>
</>
),
backCloseModal: true,
},
{
target: '#context-field-select',
content: (
<Description>
<a
href="https://docs.getunleash.io/reference/unleash-context"
target="_blank"
>
Unleash context
</a>{' '}
contains information relating to the current feature
toggle request.
</Description>
),
backCloseModal: true,
anyClick: true,
},
{
target: 'li[data-testid="SELECT_ITEM_ID-userId"]',
content: (
<Description>
Select the <Badge as="span">userId</Badge> context
field.
</Description>
),
placement: 'right',
backCloseModal: true,
},
{
target: 'div[data-testid="CONSTRAINT_VALUES_INPUT"]',
content: ( content: (
<> <>
<Description> <Description>
@ -152,7 +207,16 @@ export const TOPICS: ITutorialTopic[] = [
</Badge> </Badge>
</> </>
), ),
backCloseModal: true,
nextButton: true, nextButton: true,
},
{
target: 'button[data-testid="CONSTRAINT_VALUES_ADD_BUTTON"]',
content: <Description>Add the constraint value.</Description>,
},
{
target: 'button[data-testid="CONSTRAINT_SAVE_BUTTON"]',
content: <Description>Save the constraint.</Description>,
backCloseModal: true, backCloseModal: true,
}, },
{ {
@ -170,6 +234,7 @@ export const TOPICS: ITutorialTopic[] = [
</Badge> </Badge>
</> </>
), ),
backCloseModal: true,
}, },
{ {
target: 'button[data-testid="DIALOGUE_CONFIRM_ID"]', target: 'button[data-testid="DIALOGUE_CONFIRM_ID"]',
@ -259,6 +324,7 @@ export const TOPICS: ITutorialTopic[] = [
<Description>Change the rollout percentage.</Description> <Description>Change the rollout percentage.</Description>
), ),
backCloseModal: true, backCloseModal: true,
nextButton: true,
}, },
{ {
target: 'button[data-testid="STRATEGY_FORM_SUBMIT_ID"]', target: 'button[data-testid="STRATEGY_FORM_SUBMIT_ID"]',