Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2024-12-22 19:07:54 +01:00
Code Issues Projects Releases Wiki Activity

fix: revert overflow hidden in section, unset in modal (#3364)

Browse Source 
This reverts and adapts
https://github.com/Unleash/unleash/pull/3307/files#r1135784293 -
Apparently it broke the form border radius when not in modal mode.

This change makes it so that we have `overflow: hidden` in most cases
but `overflow: unset` when using `FormTemplate` as a modal, effectively
covering both use cases.

Normal:

![image](https://user-images.githubusercontent.com/14320932/226637777-cc8dba05-4447-4bee-b517-59d4e1dc1923.png)

Modal (`position: sticky` header in variants still works correctly):

![image](https://user-images.githubusercontent.com/14320932/226637986-bb744c3f-822b-454b-b058-450e7263bf5f.png)
This commit is contained in:
Nuno Góis 2023-03-22 09:58:39 +00:00 committed by GitHub
parent f70b33d324
commit 6c697615dc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
frontend/src/component/common/FormTemplate/FormTemplate.tsx
View File

@ -36,6 +36,7 @@ const StyledContainer = styled('section', {
width: '100%', width: '100%',
display: 'flex', display: 'flex',
margin: '0 auto', margin: '0 auto',
overflow: modal ? 'unset' : 'hidden',
[theme.breakpoints.down(1100)]: { [theme.breakpoints.down(1100)]: {
flexDirection: 'column', flexDirection: 'column',
minHeight: 0, minHeight: 0,