Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-03-18 00:19:49 +01:00
Code Issues Projects Releases Wiki Activity

fix: when finding median time to production, ignore 0s (#7200)

Browse Source 
We have an issue that if you open up Insights, the Time to Production
chart was showing nothing because it was taking the median across all
projects. You might have many new or empty projects where the median was
0 (no data).

For example, the median from [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1.7, 50.3, 140] was 0.

Now, we will remove the 0 values to have a more reasonable median.
This commit is contained in:
Jaanus Sellin 2024-05-29 14:17:31 +03:00 committed by GitHub
parent 439ee63387
commit 6c8b1d8904
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 60 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
frontend/src/component/insights/hooks/useFilteredFlagsSummary.test.ts
View File

@ -171,7 +171,61 @@ describe('useFilteredFlagTrends', () => {
averageUsers: 0,
averageHealth: undefined,
flagsPerUser: '0.00',
medianTimeToProduction: 0,
medianTimeToProduction: undefined,
});
});
it('should not use 0 timeToProduction projects for median calculation', () => {
const { result } = renderHook(() =>
useFilteredFlagsSummary(
[
{
week: '2024-01',
project: 'project1',
total: 0,
active: 0,
stale: 0,
potentiallyStale: 0,
users: 0,
date: '',
timeToProduction: 0,
},
{
week: '2024-01',
project: 'project2',
total: 0,
active: 0,
stale: 0,
potentiallyStale: 0,
users: 0,
date: '',
timeToProduction: 0,
},
{
week: '2024-01',
project: 'project3',
total: 0,
active: 0,
stale: 0,
potentiallyStale: 0,
users: 0,
date: '',
timeToProduction: 5,
},
],
{ total: 1 } as unknown as InstanceInsightsSchemaUsers,
),
);
expect(result.current).toEqual({
total: 0,
active: 0,
stale: 0,
potentiallyStale: 0,
averageUsers: 0,
averageHealth: undefined,
flagsPerUser: '0.00',
medianTimeToProduction: 5,
});
});
});

5
frontend/src/component/insights/hooks/useFilteredFlagsSummary.ts
View File

@ -6,7 +6,10 @@ import type {
const validTimeToProduction = (
item: InstanceInsightsSchemaProjectFlagTrendsItem,
) => Boolean(item) && typeof item.timeToProduction === 'number';
) =>
Boolean(item) &&
typeof item.timeToProduction === 'number' &&
item.timeToProduction !== 0;
// NOTE: should we move project filtering to the backend?
export const useFilteredFlagsSummary = (

2
src/test/e2e/api/admin/playground.e2e.test.ts
View File

@ -142,7 +142,7 @@ describe('Playground API E2E', () => {
);
};
test('Returned features should be a subset of the provided toggles', async () => {
test('Returned features should be a subset of the provided flags', async () => {
await fc.assert(
fc
.asyncProperty(