Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-03-18 00:19:49 +01:00
Code Issues Projects Releases Wiki Activity

refactor: extract add strategy diff (#8877)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2024-11-28 10:12:55 +01:00 committed by GitHub
parent 0d72cfbba8
commit 6e9b65b09c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 100 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
frontend/src/component/changeRequest/ChangeRequest/Changes/Change/StrategyChange.test.tsx
View File

@ -284,3 +284,52 @@ test('Deleting strategy after change request is applied diffs against the snapsh
await screen.findByText('Deleting strategy variants:'); await screen.findByText('Deleting strategy variants:');
await screen.findByText('snapshot_variant'); await screen.findByText('snapshot_variant');
}); });
test('Adding strategy always diffs against undefined strategy', async () => {
render(
<Routes>
<Route
path='/projects/:projectId'
element={
<StrategyChange
featureName={feature}
environmentName={environmentName}
projectId={projectId}
changeRequestState='Approved'
change={{
action: 'addStrategy',
id: 1,
payload: {
...strategy,
variants: [
{
name: 'change_variant',
weight: 1000,
stickiness: 'default',
weightType: 'variable' as const,
},
],
title: 'change_request_title',
parameters: {
...strategy.parameters,
rollout: changeRequestRollout,
},
},
}}
/>
}
/>
</Routes>,
{ route: `/projects/${projectId}` },
);
await screen.findByText('+ Adding strategy:');
await screen.findByText('change_request_title');
const viewDiff = await screen.findByText('View Diff');
await userEvent.hover(viewDiff);
await screen.findByText(`+ name: "flexibleRollout"`);
await screen.findByText('Setting strategy variants to:');
await screen.findByText('change_variant');
});

94
frontend/src/component/changeRequest/ChangeRequest/Changes/Change/StrategyChange.tsx
View File

@ -267,6 +267,56 @@ const UpdateStrategy: FC<{
); );
}; };
const AddStrategy: FC<{
change: IChangeRequestAddStrategy;
actions?: ReactNode;
}> = ({ change, actions }) => {
return (
<>
<ChangeItemCreateEditDeleteWrapper>
<ChangeItemInfo>
<Typography
color={
change.payload?.disabled
? 'action.disabled'
: 'success.dark'
}
>
+ Adding strategy:
</Typography>
<StrategyTooltipLink
name={change.payload.name}
title={change.payload.title}
>
<StrategyDiff
change={change}
currentStrategy={undefined}
/>
</StrategyTooltipLink>
<div>
<DisabledEnabledState
disabled
show={change.payload?.disabled === true}
/>
</div>
</ChangeItemInfo>
<div>{actions}</div>
</ChangeItemCreateEditDeleteWrapper>
<StrategyExecution strategy={change.payload} />
{change.payload.variants && change.payload.variants.length > 0 && (
<StyledBox>
<StyledTypography>
Setting strategy variants to:
</StyledTypography>
<EnvironmentVariantsTable
variants={change.payload.variants}
/>
</StyledBox>
)}
</>
);
};
export const StrategyChange: FC<{ export const StrategyChange: FC<{
actions?: ReactNode; actions?: ReactNode;
change: change:
@ -295,49 +345,7 @@ export const StrategyChange: FC<{
return ( return (
<> <>
{change.action === 'addStrategy' && ( {change.action === 'addStrategy' && (
<> <AddStrategy change={change} actions={actions} />
<ChangeItemCreateEditDeleteWrapper>
<ChangeItemInfo>
<Typography
color={
change.payload?.disabled
? 'action.disabled'
: 'success.dark'
}
>
+ Adding strategy:
</Typography>
<StrategyTooltipLink
name={change.payload.name}
title={change.payload.title}
>
<StrategyDiff
change={change}
currentStrategy={currentStrategy}
/>
</StrategyTooltipLink>
<div>
<DisabledEnabledState
disabled
show={change.payload?.disabled === true}
/>
</div>
</ChangeItemInfo>
<div>{actions}</div>
</ChangeItemCreateEditDeleteWrapper>
<StrategyExecution strategy={change.payload} />
{change.payload.variants &&
change.payload.variants.length > 0 && (
<StyledBox>
<StyledTypography>
Setting strategy variants to:
</StyledTypography>
<EnvironmentVariantsTable
variants={change.payload.variants}
/>
</StyledBox>
)}
</>
)} )}
{change.action === 'deleteStrategy' && ( {change.action === 'deleteStrategy' && (
<DeleteStrategy <DeleteStrategy