From 6f7f48a361f44672120f1a0c3e8e87ff2a91ddf5 Mon Sep 17 00:00:00 2001
From: Mateusz Kwasniewski <kwasniewski.mateusz@gmail.com>
Date: Tue, 17 Jun 2025 17:20:39 +0200
Subject: [PATCH] Revert "chore: use logger instead of console.error" (#10153)

Reverts Unleash/unleash#10150
---
 .../client-metrics/metrics-service-v2.ts      | 26 +++++--------------
 .../features/scheduler/schedule-services.ts   |  4 +--
 2 files changed, 9 insertions(+), 21 deletions(-)

diff --git a/src/lib/features/metrics/client-metrics/metrics-service-v2.ts b/src/lib/features/metrics/client-metrics/metrics-service-v2.ts
index be8ede5511..00271320a9 100644
--- a/src/lib/features/metrics/client-metrics/metrics-service-v2.ts
+++ b/src/lib/features/metrics/client-metrics/metrics-service-v2.ts
@@ -72,13 +72,7 @@ export default class ClientMetricsServiceV2 {
     }
 
     async clearMetrics(hoursAgo: number) {
-        try {
-            await this.clientMetricsStoreV2.clearMetrics(hoursAgo);
-        } catch (e) {
-            this.logger.warn(
-                `Failed to clear client metrics older than ${hoursAgo} hours: ${e.message}`,
-            );
-        }
+        return this.clientMetricsStoreV2.clearMetrics(hoursAgo);
     }
 
     async clearDailyMetrics(daysAgo: number) {
@@ -266,18 +260,12 @@ export default class ClientMetricsServiceV2 {
 
     async bulkAdd(): Promise<void> {
         if (this.unsavedMetrics.length > 0) {
-            try {
-                // Make a copy of `unsavedMetrics` in case new metrics
-                // arrive while awaiting `batchInsertMetrics`.
-                const copy = [...this.unsavedMetrics];
-                this.unsavedMetrics = [];
-                await this.clientMetricsStoreV2.batchInsertMetrics(copy);
-                this.config.eventBus.emit(CLIENT_METRICS_ADDED, copy);
-            } catch (error) {
-                this.logger.warn(
-                    `Failed to bulk add client metrics: ${error.message}`,
-                );
-            }
+            // Make a copy of `unsavedMetrics` in case new metrics
+            // arrive while awaiting `batchInsertMetrics`.
+            const copy = [...this.unsavedMetrics];
+            this.unsavedMetrics = [];
+            await this.clientMetricsStoreV2.batchInsertMetrics(copy);
+            this.config.eventBus.emit(CLIENT_METRICS_ADDED, copy);
         }
     }
 
diff --git a/src/lib/features/scheduler/schedule-services.ts b/src/lib/features/scheduler/schedule-services.ts
index f3f8b23257..de64a296e7 100644
--- a/src/lib/features/scheduler/schedule-services.ts
+++ b/src/lib/features/scheduler/schedule-services.ts
@@ -152,13 +152,13 @@ export const scheduleServices = (
     );
 
     schedulerService.schedule(
-        () => clientMetricsServiceV2.bulkAdd(),
+        () => clientMetricsServiceV2.bulkAdd().catch(console.error),
         secondsToMilliseconds(5),
         'bulkAddMetrics',
     );
 
     schedulerService.schedule(
-        () => clientMetricsServiceV2.clearMetrics(48),
+        () => clientMetricsServiceV2.clearMetrics(48).catch(console.error),
         hoursToMilliseconds(12),
         'clearMetrics',
     );