From 7039dd9c352b4f4bda0c7de6b4d746febb86a4e3 Mon Sep 17 00:00:00 2001
From: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
Date: Thu, 12 Oct 2023 14:57:51 +0200
Subject: [PATCH] fix: remove unneeded join

---
 .../feature-toggle-strategies-store.ts            | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/src/lib/features/feature-toggle/feature-toggle-strategies-store.ts b/src/lib/features/feature-toggle/feature-toggle-strategies-store.ts
index e76a166156..30110f7b1a 100644
--- a/src/lib/features/feature-toggle/feature-toggle-strategies-store.ts
+++ b/src/lib/features/feature-toggle/feature-toggle-strategies-store.ts
@@ -548,18 +548,7 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
                 'feature_environments.environment',
                 'environments.name',
             )
-            .leftJoin('feature_tag as ft', 'ft.feature_name', 'features.name')
-            .leftJoin('feature_strategies', function () {
-                this.on(
-                    'feature_strategies.feature_name',
-                    '=',
-                    'features.name',
-                ).andOn(
-                    'feature_strategies.environment',
-                    '=',
-                    'feature_environments.environment',
-                );
-            });
+            .leftJoin('feature_tag as ft', 'ft.feature_name', 'features.name');
 
         if (this.flagResolver.isEnabled('useLastSeenRefactor')) {
             query.leftJoin(
@@ -584,7 +573,7 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
             'environments.sort_order as environment_sort_order',
             'ft.tag_value as tag_value',
             'ft.tag_type as tag_type',
-        ] as (string | Raw<any>)[];
+        ] as (string | Raw<any> | Knex.QueryBuilder)[];
 
         if (this.flagResolver.isEnabled('useLastSeenRefactor')) {
             selectColumns.push(