Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2024-12-22 19:07:54 +01:00
Code Issues Projects Releases Wiki Activity

add joy validation to client input data

Browse Source
This commit is contained in:
sveisvei 2016-11-09 11:16:44 +01:00 committed by Ivar Conradi Østhus
parent 484f7dcd9d
commit 70d596d0af
2 changed files with 48 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
packages/unleash-api/lib/routes/metrics.js
View File

@ -3,6 +3,7 @@
const logger = require('../logger');
const ClientMetrics = require('../client-metrics');
const ClientMetricsService = require('../client-metrics/service');
const joi = require('joi');
module.exports = function (app, config) {
const {
@ -27,33 +28,67 @@ module.exports = function (app, config) {
res.json(metrics.getTogglesMetrics());
});
const clientMetricsSchema = joi.object().keys({
appName: joi.string().required(),
instanceId: joi.string().required(),
bucket: joi.object().required()
.keys({
start: joi.date().required(),
stop: joi.date().required(),
toggles: joi.object()
.required()
.unknown()
.min(1)
.max(1000),
}),
});
app.post('/client/metrics', (req, res) => {
try {
const data = typeof req.body === 'string' ? JSON.parse(req.body) : req.body;
const result = joi.validate(data, clientMetricsSchema);
if (result.error) {
throw result.error;
}
service
.insert(data)
.insert(result.value)
.catch(e => logger.error('Error inserting metrics data', e));
} catch (e) {
logger.error('Error receiving metrics', e);
}
res.end();
});
const clientRegisterSchema = joi.object().keys({
appName: joi.string().required(),
instanceId: joi.string().required(),
strategies: joi.array()
.required()
.items(joi.string(), joi.any().strip()),
started: joi.date().required(),
interval: joi.number().required(),
});
app.post('/client/register', (req, res) => {
const data = req.body;
const clientIp = req.ip;
console.log(data);
clientStrategyStore.insert(data.appName, data.strategies)
.then(() => clientInstanceStore.insert({
appName: data.appName,
instanceId: data.instanceId,
clientIp,
}))
.then(() => console.log('new client registerd'))
.catch((error) => logger.error('Error registering client', error));
res.end();
joi.validate(data, clientRegisterSchema, (err, cleaned) => {
if (err) {
return res.json(400, err);
}
clientStrategyStore.insert(cleaned.appName, cleaned.strategies)
.then(() => clientInstanceStore.insert({
appName: cleaned.appName,
instanceId: cleaned.instanceId,
clientIp,
}))
.then(() => console.log('new client registerd'))
.catch((error) => logger.error('Error registering client', error));
res.end();
});
});
app.get('/client/strategies', (req, res) => {

1
packages/unleash-api/package.json
View File

@ -57,6 +57,7 @@
"express": "4.14.0",
"express-validator": "2.20.8",
"install": "^0.8.1",
"joi": "^9.2.0",
"knex": "^0.12.6",
"log4js": "^0.6.38",
"moment": "^2.15.2",