From 71815a132005ff31aec2bf89abfb599f421c5e20 Mon Sep 17 00:00:00 2001 From: sveisvei Date: Wed, 28 Jun 2017 10:18:43 +0200 Subject: [PATCH] Remove legacy data support --- lib/data-helper/legacy-feature-mapper.js | 44 ----------- lib/data-helper/legacy-feature-mapper.test.js | 78 ------------------- 2 files changed, 122 deletions(-) delete mode 100644 lib/data-helper/legacy-feature-mapper.js delete mode 100644 lib/data-helper/legacy-feature-mapper.test.js diff --git a/lib/data-helper/legacy-feature-mapper.js b/lib/data-helper/legacy-feature-mapper.js deleted file mode 100644 index 7809cf9171..0000000000 --- a/lib/data-helper/legacy-feature-mapper.js +++ /dev/null @@ -1,44 +0,0 @@ -'use strict'; - -function addOldFields (feature) { - const modifiedFeature = Object.assign({}, feature); - if (!feature.strategies) { - modifiedFeature.strategies = []; - return modifiedFeature; - } - if (feature.strategies[0]) { - modifiedFeature.strategy = feature.strategies[0].name; - modifiedFeature.parameters = Object.assign({}, feature.strategies[0].parameters); - } - return modifiedFeature; -} - -function isOldFomrat (feature) { - return feature.strategy && !feature.strategies; -} - -function toNewFormat (feature) { - if (isOldFomrat(feature)) { - return { - name: feature.name, - description: feature.description, - enabled: feature.enabled, - strategies: [ - { - name: feature.strategy, - parameters: Object.assign({}, feature.parameters), - }, - ], - }; - } else { - return { - name: feature.name, - description: feature.description, - enabled: feature.enabled, - strategies: feature.strategies, - createdAt: feature.createdAt, - }; - } -} - -module.exports = { addOldFields, toNewFormat }; diff --git a/lib/data-helper/legacy-feature-mapper.test.js b/lib/data-helper/legacy-feature-mapper.test.js deleted file mode 100644 index 3b4842285c..0000000000 --- a/lib/data-helper/legacy-feature-mapper.test.js +++ /dev/null @@ -1,78 +0,0 @@ -'use strict'; - -const test = require('ava'); -const mapper = require('./legacy-feature-mapper'); - -test('adds old fields to feature', t => { - const feature = { - name: 'test', - enabled: 0, - strategies: [{ - name: 'default', - parameters: { - val: 'bar', - }, - }], - }; - - const mappedFeature = mapper.addOldFields(feature); - - t.true(mappedFeature.name === feature.name); - t.true(mappedFeature.enabled === feature.enabled); - t.true(mappedFeature.strategy === feature.strategies[0].name); - t.true(mappedFeature.parameters !== feature.strategies[0].parameters); - t.deepEqual(mappedFeature.parameters, feature.strategies[0].parameters); -}); - -test('adds old fields to feature handles missing strategies field', t => { - const feature = { - name: 'test', - enabled: 0, - }; - - const mappedFeature = mapper.addOldFields(feature); - - t.true(mappedFeature.name === feature.name); - t.true(mappedFeature.enabled === feature.enabled); - t.true(mappedFeature.strategies.length === 0); -}); - -test('transforms fields to new format', t => { - const feature = { - name: 'test', - enabled: 0, - strategy: 'default', - parameters: { - val: 'bar', - }, - }; - - const mappedFeature = mapper.toNewFormat(feature); - - t.true(mappedFeature.name === feature.name); - t.true(mappedFeature.enabled === feature.enabled); - t.true(mappedFeature.strategies.length === 1); - t.true(mappedFeature.strategies[0].name === feature.strategy); - t.deepEqual(mappedFeature.strategies[0].parameters, feature.parameters); - t.true(mappedFeature.strategy === undefined); - t.true(mappedFeature.parameters === undefined); -}); - -test('should not transform if it already is the new format', t => { - const feature = { - name: 'test', - enabled: 0, - description: 'test', - createdAt: new Date(), - strategies: [{ - name: 'default', - parameters: { - val: 'bar', - }, - }], - }; - - const mappedFeature = mapper.toNewFormat(feature); - - t.deepEqual(mappedFeature, feature); -});