From 7281e8b2d38f9aaf32c920bd6d97f028d6645651 Mon Sep 17 00:00:00 2001 From: andreas-unleash Date: Tue, 14 Nov 2023 14:58:48 +0200 Subject: [PATCH] fix: new SCHEDULED_CHANGE_REQUEST_EXECUTED on scheduled cr execution (#5330) Rename event to SCHEDULED_CHANGE_REQUEST_EXECUTED This event will be triggered when the executor runs a scheduled change request. The ChangeRequestApplied event will remain as is (going out to project members - but will have a scheduled = true property in the data if it scheduled. This new event will fire on execution of the schedule and have a result = "failed" | "succeeded" property. Because notifications are tied to events, this notification will go out to the creator and the applier --------- Signed-off-by: andreas-unleash --- src/lib/types/events.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/lib/types/events.ts b/src/lib/types/events.ts index 2d3a4513de..8b81658afe 100644 --- a/src/lib/types/events.ts +++ b/src/lib/types/events.ts @@ -127,8 +127,8 @@ export const CHANGE_REQUEST_CANCELLED = 'change-request-cancelled' as const; export const CHANGE_REQUEST_SENT_TO_REVIEW = 'change-request-sent-to-review' as const; export const CHANGE_REQUEST_APPLIED = 'change-request-applied' as const; -export const SCHEDULED_CHANGE_REQUEST_APPLIED = - 'scheduled-change-request-applied' as const; +export const SCHEDULED_CHANGE_REQUEST_EXECUTED = + 'scheduled-change-request-executed' as const; export const CHANGE_REQUEST_SCHEDULED = 'change-request-scheduled' as const; export const API_TOKEN_CREATED = 'api-token-created' as const; @@ -249,8 +249,8 @@ export const IEventTypes = [ CHANGE_REQUEST_APPROVAL_ADDED, CHANGE_REQUEST_CANCELLED, CHANGE_REQUEST_SENT_TO_REVIEW, + SCHEDULED_CHANGE_REQUEST_EXECUTED, CHANGE_REQUEST_APPLIED, - SCHEDULED_CHANGE_REQUEST_APPLIED, CHANGE_REQUEST_SCHEDULED, API_TOKEN_CREATED, API_TOKEN_UPDATED,