From 7336bc3ef67d160b779d3b7b668c5421555c0d8c Mon Sep 17 00:00:00 2001 From: Fredrik Strand Oseberg Date: Fri, 4 Feb 2022 10:13:18 +0100 Subject: [PATCH] Fix/account for missing environments (#673) * fix: add guards * fix: remove console log * fix: remove file * fix: remove console log --- .../FeatureOverviewEnvironment/FeatureOverviewEnvironment.tsx | 2 ++ .../FeatureOverviewEnvironmentMetrics.tsx | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/frontend/src/component/feature/FeatureView2/FeatureOverview/FeatureOverviewEnvironments/FeatureOverviewEnvironment/FeatureOverviewEnvironment.tsx b/frontend/src/component/feature/FeatureView2/FeatureOverview/FeatureOverviewEnvironments/FeatureOverviewEnvironment/FeatureOverviewEnvironment.tsx index 2e76a0c060..e4180bd634 100644 --- a/frontend/src/component/feature/FeatureView2/FeatureOverview/FeatureOverviewEnvironments/FeatureOverviewEnvironment/FeatureOverviewEnvironment.tsx +++ b/frontend/src/component/feature/FeatureView2/FeatureOverview/FeatureOverviewEnvironments/FeatureOverviewEnvironment/FeatureOverviewEnvironment.tsx @@ -81,6 +81,8 @@ const FeatureOverviewEnvironment = ({ {} as { [key: string]: IStrategyIconObject } ); + if (!strategyObjects) return []; + return Object.keys(strategyObjects).map(strategyName => { return { ...strategyObjects[strategyName], name: strategyName }; }); diff --git a/frontend/src/component/feature/FeatureView2/FeatureOverview/FeatureOverviewEnvironments/FeatureOverviewEnvironment/FeatureOverviewEnvironmentMetrics/FeatureOverviewEnvironmentMetrics.tsx b/frontend/src/component/feature/FeatureView2/FeatureOverview/FeatureOverviewEnvironments/FeatureOverviewEnvironment/FeatureOverviewEnvironmentMetrics/FeatureOverviewEnvironmentMetrics.tsx index f0ff52afba..5ac9cac595 100644 --- a/frontend/src/component/feature/FeatureView2/FeatureOverview/FeatureOverviewEnvironments/FeatureOverviewEnvironment/FeatureOverviewEnvironmentMetrics/FeatureOverviewEnvironmentMetrics.tsx +++ b/frontend/src/component/feature/FeatureView2/FeatureOverview/FeatureOverviewEnvironments/FeatureOverviewEnvironment/FeatureOverviewEnvironmentMetrics/FeatureOverviewEnvironmentMetrics.tsx @@ -13,8 +13,10 @@ const FeatureOverviewEnvironmentMetrics = ({ }: IFeatureOverviewEnvironmentMetrics) => { const styles = useStyles(); + if (!environmentMetric) return null; + const total = environmentMetric.yes + environmentMetric.no; - const percentage = calculatePercentage(total, environmentMetric.yes); + const percentage = calculatePercentage(total, environmentMetric?.yes); if ( !environmentMetric ||