Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-14 00:19:16 +01:00
Code Issues Projects Releases Wiki Activity

refactor: rename createdAtFrom/To to from/to (#7773)

Browse Source 
Update the query parameter of the new event search API to match the
query parameters of the insights API
This commit is contained in:
Thomas Heartman 2024-08-06 15:02:44 +02:00 committed by GitHub
parent f9665233cc
commit 76bc7bf250
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 11 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
frontend/src/openapi/models/searchEventsParams.ts
View File

@ -28,11 +28,11 @@ export type SearchEventsParams = {
/**
* The starting date of the creation date range in IS:yyyy-MM-dd format
*/
createdAtFrom?: string;
from?: string;
/**
* The ending date of the creation date range in IS:yyyy-MM-dd format
*/
createdAtTo?: string;
to?: string;
/**
* The number of features to skip when returning a page. By default it is set to 0.
*/

14
src/lib/features/events/event-service.ts
View File

@ -146,11 +146,8 @@ export default class EventService {
convertToDbParams = (params: IEventSearchParams): IQueryParam[] => {
const queryParams: IQueryParam[] = [];
if (params.createdAtFrom) {
const parsed = parseSearchOperatorValue(
'created_at',
params.createdAtFrom,
);
if (params.from) {
const parsed = parseSearchOperatorValue('created_at', params.from);
if (parsed) {
queryParams.push({
field: parsed.field,
@ -160,11 +157,8 @@ export default class EventService {
}
}
if (params.createdAtTo) {
const parsed = parseSearchOperatorValue(
'created_at',
params.createdAtTo,
);
if (params.to) {
const parsed = parseSearchOperatorValue('created_at', params.to);
if (parsed) {
queryParams.push({
field: parsed.field,

4
src/lib/openapi/spec/event-search-query-parameters.ts
View File

@ -57,7 +57,7 @@ export const eventSearchQueryParameters = [
in: 'query',
},
{
name: 'createdAtFrom',
name: 'from',
schema: {
type: 'string',
example: 'IS:2024-01-01',
@ -68,7 +68,7 @@ export const eventSearchQueryParameters = [
in: 'query',
},
{
name: 'createdAtTo',
name: 'to',
schema: {
type: 'string',
example: 'IS:2024-01-31',

4
src/lib/types/stores/event-store.ts
View File

@ -9,8 +9,8 @@ export interface IEventSearchParams {
project?: string;
query?: string;
feature?: string;
createdAtFrom?: string;
createdAtTo?: string;
from?: string;
to?: string;
createdBy?: string;
type?: string;
offset: number;

2
src/test/e2e/api/admin/event-search.e2e.test.ts
View File

@ -228,7 +228,7 @@ test('should filter events by created date range', async () => {
const today = new Date();
const { body } = await searchEvents({
createdAtFrom: `IS:${today.toISOString().split('T')[0]}`,
from: `IS:${today.toISOString().split('T')[0]}`,
});
expect(body).toMatchObject({