Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-03-04 00:18:40 +01:00
Code Issues Projects Releases Wiki Activity

fix: delete duplicate client instances

Browse Source 
- Due to applying a primary key constraint on app_name, instance_id,
  active installations with client_instances that have already violated
  this unique constraint will fail to migrate.
- This commit drops all but the latest instance of each (app_name,
  instance_id) tuple, thus preparing the database for applying the
  unique constraint

Co-authored-by: Ivar Conradi Osthus <ivarconr@gmail.com>
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
This commit is contained in:
Christopher Kolstad 2021-03-19 11:54:12 +01:00
parent e3196675c9
commit 780464d3ad
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/migrations/20210302080040-add-pk-to-client-instances.js
View File

@ -3,6 +3,7 @@
exports.up = function(db, cb) { exports.up = function(db, cb) {
db.runSql( db.runSql(
` `
DELETE FROM client_instances a USING client_instances b WHERE a.app_name = b.app_name AND a.instance_id = b.instance_id AND a.created_at < b.created_at;
ALTER TABLE client_instances ADD PRIMARY KEY (app_name, instance_id); ALTER TABLE client_instances ADD PRIMARY KEY (app_name, instance_id);
`, `,
cb, cb,
@ -13,7 +14,7 @@ exports.down = function(db, cb) {
db.runSql( db.runSql(
` `
ALTER TABLE client_instances DROP CONSTRAINT client_instances_pkey; ALTER TABLE client_instances DROP CONSTRAINT client_instances_pkey;
DROP INDEX client_instance_pkey DROP INDEX IF EXISTS client_instance_pkey
`, `,
cb, cb,
); );