Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

chore: when some promise fails others might hang and leave open conns (#6636)

Browse Source 
This was identified during some tests where we noticed jest did not
complete properly (notice how after linking unleash-server to this
commit it didn't have that issue):

![image](https://github.com/Unleash/unleash/assets/455064/306e57b8-6473-459a-8104-7223d1de40c3)
This commit is contained in:
Gastón Fournier 2024-04-02 11:25:38 +02:00 committed by GitHub
parent a30ddd81c5
commit 783c83173f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/lib/features/feature-toggle/feature-toggle-service.ts
View File

@ -107,6 +107,7 @@ import type { FeatureToggleInsert } from './feature-toggle-store';
import ArchivedFeatureError from '../../error/archivedfeature-error'; import ArchivedFeatureError from '../../error/archivedfeature-error';
import { FEATURES_CREATED_BY_PROCESSED } from '../../metric-events'; import { FEATURES_CREATED_BY_PROCESSED } from '../../metric-events';
import type { EventEmitter } from 'stream'; import type { EventEmitter } from 'stream';
import { allSettledWithRejection } from '../../util/allSettledWithRejection';
interface IFeatureContext { interface IFeatureContext {
featureName: string; featureName: string;
@ -1717,7 +1718,7 @@ class FeatureToggleService {
user?: IUser, user?: IUser,
shouldActivateDisabledStrategies = false, shouldActivateDisabledStrategies = false,
): Promise<void> { ): Promise<void> {
await Promise.all( await allSettledWithRejection(
featureNames.map((featureName) => featureNames.map((featureName) =>
this.updateEnabled( this.updateEnabled(
project, project,