From 7906bfb1777236a973e28cc6586f19b3524dcac8 Mon Sep 17 00:00:00 2001 From: Jaanus Sellin Date: Tue, 26 Nov 2024 09:57:43 +0200 Subject: [PATCH] chore: rename toggle to flag (#8854) --- .../feature/StrategyTypes/NewStrategyVariants.tsx | 2 +- .../component/project/Project/Import/Import.test.tsx | 4 ++-- .../Project/Import/configure/ConfigurationStage.tsx | 2 +- src/lib/metrics.ts | 2 +- src/lib/openapi/spec/playground-request-schema.ts | 11 ++++++----- 5 files changed, 11 insertions(+), 10 deletions(-) diff --git a/frontend/src/component/feature/StrategyTypes/NewStrategyVariants.tsx b/frontend/src/component/feature/StrategyTypes/NewStrategyVariants.tsx index 04c2fc9b79..add4389fa1 100644 --- a/frontend/src/component/feature/StrategyTypes/NewStrategyVariants.tsx +++ b/frontend/src/component/feature/StrategyTypes/NewStrategyVariants.tsx @@ -134,7 +134,7 @@ export const NewStrategyVariants: FC<{ tooltip={ - Variants in feature toggling allow you to serve + Variants in feature flagging allow you to serve different versions of a feature to different users. This can be used for A/B testing, gradual rollouts, and canary releases. Variants provide diff --git a/frontend/src/component/project/Project/Import/Import.test.tsx b/frontend/src/component/project/Project/Import/Import.test.tsx index 3f1fd58fe9..f6ed505f5d 100644 --- a/frontend/src/component/project/Project/Import/Import.test.tsx +++ b/frontend/src/component/project/Project/Import/Import.test.tsx @@ -59,7 +59,7 @@ test('Import happy path', async () => { const codeEditorLabel = screen.getByText('Code editor'); codeEditorLabel.click(); - const editor = screen.getByLabelText('Exported toggles'); + const editor = screen.getByLabelText('Exported feature flags'); expect(editor.textContent).toBe('{}'); screen.getByText('Validate').click(); @@ -92,7 +92,7 @@ test('Block when importing non json content', async () => { const codeEditorLabel = screen.getByText('Code editor'); codeEditorLabel.click(); - const editor = await screen.findByLabelText('Exported toggles'); + const editor = await screen.findByLabelText('Exported feature flags'); await userEvent.type(editor, 'invalid non json'); const validateButton = screen.getByText('Validate'); diff --git a/frontend/src/component/project/Project/Import/configure/ConfigurationStage.tsx b/frontend/src/component/project/Project/Import/configure/ConfigurationStage.tsx index b385d2f481..77e485d8e9 100644 --- a/frontend/src/component/project/Project/Import/configure/ConfigurationStage.tsx +++ b/frontend/src/component/project/Project/Import/configure/ConfigurationStage.tsx @@ -121,7 +121,7 @@ export const ImportArea: FC<{ } elseShow={ setImportPayload(event.target.value)} value={importPayload} diff --git a/src/lib/metrics.ts b/src/lib/metrics.ts index af421a429d..480c60e9cd 100644 --- a/src/lib/metrics.ts +++ b/src/lib/metrics.ts @@ -155,7 +155,7 @@ export function registerPrometheusMetrics( }); const featureFlagUpdateTotal = createCounter({ name: 'feature_toggle_update_total', - help: 'Number of times a toggle has been updated. Environment label would be "n/a" when it is not available, e.g. when a feature flag is created.', + help: 'Number of times a flag has been updated. Environment label would be "n/a" when it is not available, e.g. when a feature flag is created.', labelNames: [ 'toggle', 'project', diff --git a/src/lib/openapi/spec/playground-request-schema.ts b/src/lib/openapi/spec/playground-request-schema.ts index 5f4341ab43..b43358f2ff 100644 --- a/src/lib/openapi/spec/playground-request-schema.ts +++ b/src/lib/openapi/spec/playground-request-schema.ts @@ -4,28 +4,29 @@ import { sdkContextSchema } from './sdk-context-schema'; export const playgroundRequestSchema = { $id: '#/components/schemas/playgroundRequestSchema', - description: 'Data for the playground API to evaluate toggles', + description: 'Data for the playground API to evaluate feature flags', type: 'object', required: ['environment', 'context'], properties: { environment: { type: 'string', example: 'development', - description: 'The environment to evaluate toggles in.', + description: 'The environment to evaluate feature flags in.', }, projects: { - description: 'A list of projects to check for toggles in.', + description: 'A list of projects to check for feature flags in.', oneOf: [ { type: 'array', items: { type: 'string' }, example: ['my-project'], - description: 'A list of projects to check for toggles in.', + description: + 'A list of projects to check for feature flags in.', }, { type: 'string', enum: [ALL], - description: 'Check toggles in all projects.', + description: 'Check feature flags in all projects.', }, ], },