From 7988abdeefa08060d9cd602d74dd88d40f647c87 Mon Sep 17 00:00:00 2001
From: Thomas Heartman <thomas@getunleash.io>
Date: Wed, 16 Jul 2025 11:25:11 +0200
Subject: [PATCH] correctly add the type

---
 src/lib/features/metrics/instance/metrics.ts | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/lib/features/metrics/instance/metrics.ts b/src/lib/features/metrics/instance/metrics.ts
index 7b9872ca54..29507bbfd9 100644
--- a/src/lib/features/metrics/instance/metrics.ts
+++ b/src/lib/features/metrics/instance/metrics.ts
@@ -27,7 +27,10 @@ import { CLIENT_METRICS } from '../../../events/index.js';
 import type { CustomMetricsSchema } from '../../../openapi/spec/custom-metrics-schema.js';
 import type { StoredCustomMetric } from '../custom/custom-metrics-store.js';
 import type { CustomMetricsService } from '../custom/custom-metrics-service.js';
-import type { MetricsTranslator } from '../impact/metrics-translator.js';
+import type {
+    Metric,
+    MetricsTranslator,
+} from '../impact/metrics-translator.js';
 import type { ClientMetricsSchema } from '../../../server-impl.js';
 
 export default class ClientMetricsController extends Controller {
@@ -149,7 +152,7 @@ export default class ClientMetricsController extends Controller {
     }
 
     async registerMetrics(
-        req: IAuthRequest<ClientMetricsSchema>,
+        req: IAuthRequest<void, void, ClientMetricsSchema>,
         res: Response,
     ): Promise<void> {
         if (this.config.flagResolver.isEnabled('disableMetrics')) {
@@ -173,7 +176,9 @@ export default class ClientMetricsController extends Controller {
                     this.flagResolver.isEnabled('impactMetrics') &&
                     impactMetrics
                 ) {
-                    await this.metricsV2.registerImpactMetrics(impactMetrics);
+                    await this.metricsV2.registerImpactMetrics(
+                        impactMetrics as Metric[],
+                    );
                 }
 
                 res.getHeaderNames().forEach((header) =>