Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-07-26 13:48:33 +02:00
Code Issues Projects Releases Wiki Activity

fix: move useUiFlag before "return null" to avoid rendering more hooks on the first render (#5258)

Browse Source 
Move the hook to before the first return to avoid React erroring out.
This commit is contained in:
Thomas Heartman 2023-11-03 11:04:03 +01:00 committed by GitHub
parent fe61947435
commit 7cf998c509
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
frontend/src/component/changeRequest/ChangeRequestOverview/ChangeRequestOverview.tsx
View File

@ -86,12 +86,12 @@ export const ChangeRequestOverview: FC = () => {
const { isChangeRequestConfiguredForReview } = const { isChangeRequestConfiguredForReview } =
useChangeRequestsEnabled(projectId); useChangeRequestsEnabled(projectId);
const scheduleChangeRequests = useUiFlag('scheduledConfigurationChanges');
if (!changeRequest) { if (!changeRequest) {
return null; return null;
} }
const scheduleChangeRequests = useUiFlag('scheduledConfigurationChanges');
const allowChangeRequestActions = isChangeRequestConfiguredForReview( const allowChangeRequestActions = isChangeRequestConfiguredForReview(
changeRequest.environment, changeRequest.environment,
); );