Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2024-12-22 19:07:54 +01:00
Code Issues Projects Releases Wiki Activity

fix: clickable names in inc wh and action tables (#6275)

Browse Source 
https://linear.app/unleash/issue/2-1954/make-names-clickable-in-actions-and-incoming-webhooks

Makes names clickable in the incoming webhook and action tables. When
clicked, they open the edit form for that resource.


![image](https://github.com/Unleash/unleash/assets/14320932/973f38c0-2603-4cbf-9352-90ddfe0b6e3f)


![image](https://github.com/Unleash/unleash/assets/14320932/ff733899-b86a-494a-8d2c-65d53e19a356)
This commit is contained in:
Nuno Góis 2024-02-20 09:28:00 +00:00 committed by GitHub
parent 86b9ba79d7
commit 7e6a3c7e69
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
frontend/src/component/incomingWebhooks/IncomingWebhooksTable/IncomingWebhooksTable.tsx
View File

@ -16,12 +16,12 @@ import { IIncomingWebhook } from 'interfaces/incomingWebhook';
import { IncomingWebhooksActionsCell } from './IncomingWebhooksActionsCell';
import { IncomingWebhooksDeleteDialog } from './IncomingWebhooksDeleteDialog';
import { ToggleCell } from 'component/common/Table/cells/ToggleCell/ToggleCell';
import { HighlightCell } from 'component/common/Table/cells/HighlightCell/HighlightCell';
import copy from 'copy-to-clipboard';
import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig';
import { IncomingWebhookTokensCell } from './IncomingWebhooksTokensCell';
import { IncomingWebhooksModal } from '../IncomingWebhooksModal/IncomingWebhooksModal';
import { IncomingWebhooksTokensDialog } from '../IncomingWebhooksModal/IncomingWebhooksForm/IncomingWebhooksTokens/IncomingWebhooksTokensDialog';
import { LinkCell } from 'component/common/Table/cells/LinkCell/LinkCell';
interface IIncomingWebhooksTableProps {
modalOpen: boolean;
@ -91,8 +91,12 @@ export const IncomingWebhooksTable = ({
Cell: ({
row: { original: incomingWebhook },
}: { row: { original: IIncomingWebhook } }) => (
<HighlightCell
value={incomingWebhook.name}
<LinkCell
title={incomingWebhook.name}
onClick={() => {
setSelectedIncomingWebhook(incomingWebhook);
setModalOpen(true);
}}
subtitle={incomingWebhook.description}
/>
),

12
frontend/src/component/project/Project/ProjectSettings/ProjectActions/ProjectActionsTable/ProjectActionsTable.tsx
View File

@ -23,6 +23,7 @@ import { ProjectActionsDeleteDialog } from './ProjectActionsDeleteDialog';
import { useServiceAccounts } from 'hooks/api/getters/useServiceAccounts/useServiceAccounts';
import { useIncomingWebhooks } from 'hooks/api/getters/useIncomingWebhooks/useIncomingWebhooks';
import { useRequiredPathParam } from 'hooks/useRequiredPathParam';
import { LinkCell } from 'component/common/Table/cells/LinkCell/LinkCell';
interface IProjectActionsTableProps {
modalOpen: boolean;
@ -88,6 +89,17 @@ export const ProjectActionsTable = ({
Header: 'Name',
accessor: 'name',
minWidth: 60,
Cell: ({
row: { original: action },
}: { row: { original: IActionSet } }) => (
<LinkCell
title={action.name}
onClick={() => {
setSelectedAction(action);
setModalOpen(true);
}}
/>
),
},
{
id: 'trigger',