mirror of
https://github.com/Unleash/unleash.git
synced 2025-04-01 01:18:10 +02:00
fix: datadog addon needs flagResolver (#4806)
Fixes what this breaks: https://github.com/Unleash/unleash/pull/4765 - The Datadog integration needs a `flagResolver`.
This commit is contained in:
parent
ea9901c968
commit
7eae1f8382
@ -5,6 +5,7 @@ import DatadogAddon from './datadog';
|
|||||||
import Addon from './addon';
|
import Addon from './addon';
|
||||||
import { LogProvider } from '../logger';
|
import { LogProvider } from '../logger';
|
||||||
import SlackAppAddon from './slack-app';
|
import SlackAppAddon from './slack-app';
|
||||||
|
import { IFlagResolver } from '../types';
|
||||||
|
|
||||||
export interface IAddonProviders {
|
export interface IAddonProviders {
|
||||||
[key: string]: Addon;
|
[key: string]: Addon;
|
||||||
@ -13,7 +14,8 @@ export interface IAddonProviders {
|
|||||||
export const getAddons: (args: {
|
export const getAddons: (args: {
|
||||||
getLogger: LogProvider;
|
getLogger: LogProvider;
|
||||||
unleashUrl: string;
|
unleashUrl: string;
|
||||||
}) => IAddonProviders = ({ getLogger, unleashUrl }) => {
|
flagResolver: IFlagResolver;
|
||||||
|
}) => IAddonProviders = ({ getLogger, unleashUrl, flagResolver }) => {
|
||||||
const addons: Addon[] = [
|
const addons: Addon[] = [
|
||||||
new Webhook({ getLogger }),
|
new Webhook({ getLogger }),
|
||||||
new SlackAddon({ getLogger, unleashUrl }),
|
new SlackAddon({ getLogger, unleashUrl }),
|
||||||
|
@ -49,7 +49,11 @@ export default class AddonService {
|
|||||||
IUnleashStores,
|
IUnleashStores,
|
||||||
'addonStore' | 'eventStore' | 'featureToggleStore'
|
'addonStore' | 'eventStore' | 'featureToggleStore'
|
||||||
>,
|
>,
|
||||||
{ getLogger, server }: Pick<IUnleashConfig, 'getLogger' | 'server'>,
|
{
|
||||||
|
getLogger,
|
||||||
|
server,
|
||||||
|
flagResolver,
|
||||||
|
}: Pick<IUnleashConfig, 'getLogger' | 'server' | 'flagResolver'>,
|
||||||
tagTypeService: TagTypeService,
|
tagTypeService: TagTypeService,
|
||||||
addons?: IAddonProviders,
|
addons?: IAddonProviders,
|
||||||
) {
|
) {
|
||||||
@ -64,6 +68,7 @@ export default class AddonService {
|
|||||||
getAddons({
|
getAddons({
|
||||||
getLogger,
|
getLogger,
|
||||||
unleashUrl: server.unleashUrl,
|
unleashUrl: server.unleashUrl,
|
||||||
|
flagResolver,
|
||||||
});
|
});
|
||||||
this.sensitiveParams = this.loadSensitiveParams(this.addonProviders);
|
this.sensitiveParams = this.loadSensitiveParams(this.addonProviders);
|
||||||
if (addonStore) {
|
if (addonStore) {
|
||||||
|
Loading…
Reference in New Issue
Block a user