From 7f83ea730f6dc7e097a82a0aa5804d01c11d6b69 Mon Sep 17 00:00:00 2001 From: Thomas Heartman Date: Fri, 29 Aug 2025 10:59:14 +0200 Subject: [PATCH] Make the creation archive stats widget do the same thing and handle NaNs --- .../CreationArchiveChart/CreationArchiveRatioTooltip.tsx | 6 ++---- .../CreationArchiveStats/CreationArchiveStats.tsx | 5 ++--- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/frontend/src/component/insights/componentsChart/CreationArchiveChart/CreationArchiveRatioTooltip.tsx b/frontend/src/component/insights/componentsChart/CreationArchiveChart/CreationArchiveRatioTooltip.tsx index 54e7a240b3..c6b6cffc7c 100644 --- a/frontend/src/component/insights/componentsChart/CreationArchiveChart/CreationArchiveRatioTooltip.tsx +++ b/frontend/src/component/insights/componentsChart/CreationArchiveChart/CreationArchiveRatioTooltip.tsx @@ -50,10 +50,8 @@ export const CreationArchiveRatioTooltip: FC< const archivedCount = rawData.archivedFlags || 0; const createdCount = rawData.totalCreatedFlags || 0; - const ratio = Math.min( - Math.round((archivedCount / createdCount) * 100), - 100, - ); + const rawRatio = Math.round((archivedCount / createdCount) * 100); + const ratio = Number.isNaN(rawRatio) ? 100 : Math.min(rawRatio, 100); return ( diff --git a/frontend/src/component/insights/componentsStat/CreationArchiveStats/CreationArchiveStats.tsx b/frontend/src/component/insights/componentsStat/CreationArchiveStats/CreationArchiveStats.tsx index c250bf5c66..c306597747 100644 --- a/frontend/src/component/insights/componentsStat/CreationArchiveStats/CreationArchiveStats.tsx +++ b/frontend/src/component/insights/componentsStat/CreationArchiveStats/CreationArchiveStats.tsx @@ -34,9 +34,8 @@ function getCurrentArchiveRatio( } }); - return totalCreated > 0 - ? Math.round((totalArchived / totalCreated) * 100) - : 0; + const rawRatio = Math.round((totalArchived / totalCreated) * 100); + return Number.isNaN(rawRatio) ? 100 : Math.min(rawRatio, 100); } const StyledRatioContainer = styled(Box)(({ theme }) => ({