Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-20 00:08:02 +01:00
Code Issues Projects Releases Wiki Activity

fix: attempt to unflake the feature e2e tests (#1940)

Browse Source
This commit is contained in:
olav 2022-08-18 12:35:45 +02:00 committed by GitHub
parent 14b1540715
commit 831380333e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/test/e2e/api/admin/feature.e2e.test.ts
View File

@ -1,4 +1,3 @@
import faker from 'faker';
import dbInit, { ITestDb } from '../../helpers/database-init'; import dbInit, { ITestDb } from '../../helpers/database-init';
import { import {
IUnleashTest, IUnleashTest,
@ -12,6 +11,7 @@ import {
IStrategyConfig, IStrategyConfig,
IVariant, IVariant,
} from '../../../../lib/types/model'; } from '../../../../lib/types/model';
import { randomId } from '../../../../lib/util/random-id';
let app: IUnleashTest; let app: IUnleashTest;
let db: ITestDb; let db: ITestDb;
@ -580,7 +580,7 @@ test('tagging a feature with an already existing tag should be a noop', async ()
test('can untag feature', async () => { test('can untag feature', async () => {
expect.assertions(1); expect.assertions(1);
const feature1Name = faker.datatype.uuid(); const feature1Name = randomId();
await app.request.post('/api/admin/features').send({ await app.request.post('/api/admin/features').send({
name: feature1Name, name: feature1Name,
type: 'killswitch', type: 'killswitch',
@ -588,7 +588,7 @@ test('can untag feature', async () => {
strategies: [{ name: 'default' }], strategies: [{ name: 'default' }],
}); });
const tag = { const tag = {
value: faker.lorem.word(), value: randomId(),
type: 'simple', type: 'simple',
}; };
await app.request await app.request
@ -611,8 +611,8 @@ test('can untag feature', async () => {
test('Can get features tagged by tag', async () => { test('Can get features tagged by tag', async () => {
expect.assertions(2); expect.assertions(2);
const feature1Name = faker.datatype.uuid(); const feature1Name = randomId();
const feature2Name = faker.datatype.uuid(); const feature2Name = randomId();
await app.request.post('/api/admin/features').send({ await app.request.post('/api/admin/features').send({
name: feature1Name, name: feature1Name,
type: 'killswitch', type: 'killswitch',
@ -625,7 +625,7 @@ test('Can get features tagged by tag', async () => {
enabled: true, enabled: true,
strategies: [{ name: 'default' }], strategies: [{ name: 'default' }],
}); });
const tag = { value: faker.lorem.word(), type: 'simple' }; const tag = { value: randomId(), type: 'simple' };
await app.request await app.request
.post(`/api/admin/features/${feature1Name}/tags`) .post(`/api/admin/features/${feature1Name}/tags`)
.send(tag) .send(tag)
@ -641,8 +641,8 @@ test('Can get features tagged by tag', async () => {
}); });
test('Can query for multiple tags using OR', async () => { test('Can query for multiple tags using OR', async () => {
expect.assertions(3); expect.assertions(3);
const feature1Name = faker.datatype.uuid(); const feature1Name = randomId();
const feature2Name = faker.datatype.uuid(); const feature2Name = randomId();
await app.request.post('/api/admin/features').send({ await app.request.post('/api/admin/features').send({
name: feature1Name, name: feature1Name,
type: 'killswitch', type: 'killswitch',
@ -655,8 +655,8 @@ test('Can query for multiple tags using OR', async () => {
enabled: true, enabled: true,
strategies: [{ name: 'default' }], strategies: [{ name: 'default' }],
}); });
const tag = { value: faker.name.firstName(), type: 'simple' }; const tag = { value: randomId(), type: 'simple' };
const tag2 = { value: faker.name.firstName(), type: 'simple' }; const tag2 = { value: randomId(), type: 'simple' };
await app.request await app.request
.post(`/api/admin/features/${feature1Name}/tags`) .post(`/api/admin/features/${feature1Name}/tags`)
.send(tag) .send(tag)
@ -682,8 +682,9 @@ test('Can query for multiple tags using OR', async () => {
}); });
}); });
test('Querying with multiple filters ANDs the filters', async () => { test('Querying with multiple filters ANDs the filters', async () => {
const feature1Name = `test.${faker.datatype.uuid()}`; const feature1Name = `test.${randomId()}`;
const feature2Name = faker.datatype.uuid(); const feature2Name = randomId();
const feature3Name = `notestprefix.${randomId()}`;
await app.request.post('/api/admin/features').send({ await app.request.post('/api/admin/features').send({
name: feature1Name, name: feature1Name,
@ -698,13 +699,13 @@ test('Querying with multiple filters ANDs the filters', async () => {
strategies: [{ name: 'default' }], strategies: [{ name: 'default' }],
}); });
await app.request.post('/api/admin/features').send({ await app.request.post('/api/admin/features').send({
name: 'notestprefix.feature3', name: feature3Name,
type: 'release', type: 'release',
enabled: true, enabled: true,
strategies: [{ name: 'default' }], strategies: [{ name: 'default' }],
}); });
const tag = { value: faker.lorem.word(), type: 'simple' }; const tag = { value: randomId(), type: 'simple' };
const tag2 = { value: faker.name.firstName(), type: 'simple' }; const tag2 = { value: randomId(), type: 'simple' };
await app.request await app.request
.post(`/api/admin/features/${feature1Name}/tags`) .post(`/api/admin/features/${feature1Name}/tags`)
.send(tag) .send(tag)
@ -714,7 +715,7 @@ test('Querying with multiple filters ANDs the filters', async () => {
.send(tag2) .send(tag2)
.expect(201); .expect(201);
await app.request await app.request
.post('/api/admin/features/notestprefix.feature3/tags') .post(`/api/admin/features/${feature3Name}/tags`)
.send(tag) .send(tag)
.expect(201); .expect(201);
await app.request await app.request
@ -733,7 +734,7 @@ test('Querying with multiple filters ANDs the filters', async () => {
}); });
test('Tagging a feature with a tag it already has should return 409', async () => { test('Tagging a feature with a tag it already has should return 409', async () => {
const feature1Name = `test.${faker.datatype.uuid()}`; const feature1Name = `test.${randomId()}`;
await app.request.post('/api/admin/features').send({ await app.request.post('/api/admin/features').send({
name: feature1Name, name: feature1Name,
type: 'killswitch', type: 'killswitch',
@ -741,7 +742,7 @@ test('Tagging a feature with a tag it already has should return 409', async () =
strategies: [{ name: 'default' }], strategies: [{ name: 'default' }],
}); });
const tag = { value: faker.lorem.word(), type: 'simple' }; const tag = { value: randomId(), type: 'simple' };
await app.request await app.request
.post(`/api/admin/features/${feature1Name}/tags`) .post(`/api/admin/features/${feature1Name}/tags`)
.send(tag) .send(tag)