From 84a3a4cb61cf7bdce999b1abb771f6e2c9b9e757 Mon Sep 17 00:00:00 2001
From: andreas-unleash <andreas@getunleash.ai>
Date: Wed, 7 Jun 2023 15:35:20 +0300
Subject: [PATCH] fix: remove unneseccary constraint validation request (#3914)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!-- Thanks for creating a PR! To make it easier for reviewers and
everyone else to understand what your changes relate to, please add some
relevant content to the headings below. Feel free to ignore or delete
sections that you don't think are relevant. Thank you! ❤️ -->
Fixes over-validating constraint
## About the changes
<!-- Describe the changes introduced. What are they and why are they
being introduced? Feel free to also add screenshots or steps to view the
changes if they're visual. -->

<!-- Does it close an issue? Multiple? -->
Closes #
[1-949](https://linear.app/unleash/issue/1-949/fix-overvalidating-constraint)

<!-- (For internal contributors): Does it relate to an issue on public
roadmap? -->
<!--
Relates to [roadmap](https://github.com/orgs/Unleash/projects/10) item:
#
-->

### Important files
<!-- PRs can contain a lot of changes, but not all changes are equally
important. Where should a reviewer start looking to get an overview of
the changes? Are any files particularly important? -->


## Discussion points
<!-- Anything about the PR you'd like to discuss before it gets merged?
Got any questions or doubts? -->

---------

Signed-off-by: andreas-unleash <andreas@getunleash.ai>
---
 .../useConstraintsValidation.ts                   | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/frontend/src/hooks/api/getters/useConstraintsValidation/useConstraintsValidation.ts b/frontend/src/hooks/api/getters/useConstraintsValidation/useConstraintsValidation.ts
index 944404d4e3..c3e759119d 100644
--- a/frontend/src/hooks/api/getters/useConstraintsValidation/useConstraintsValidation.ts
+++ b/frontend/src/hooks/api/getters/useConstraintsValidation/useConstraintsValidation.ts
@@ -16,9 +16,18 @@ export const useConstraintsValidation = (
             return;
         }
 
-        const validationRequests = constraints.map(constraint => {
-            return validateConstraint(constraint);
-        });
+        const validationRequests = constraints
+            .filter(constraint => {
+                const hasValues =
+                    Array.isArray(constraint.values) &&
+                    constraint.values.length > 0;
+                const hasValue = Boolean(constraint.value);
+
+                return hasValues || hasValue;
+            })
+            .map(constraint => {
+                return validateConstraint(constraint);
+            });
 
         Promise.all(validationRequests)
             .then(() => setValid(true))