Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-23 00:22:19 +01:00
Code Issues Projects Releases Wiki Activity

fix: feature toggle update total needs 4 labels (#5946)

Browse Source 
So, this was causing a lot of ERROR in our logs, due to the metric
having gotten an extra label the last month.

Two things for this fix.
1. add the missing label to the two calls that did not have it added
2. update the log line to include the error as another argument to the
logger, so we actually get a stacktrace from the error.
This commit is contained in:
Christopher Kolstad 2024-01-18 11:00:56 +01:00 committed by GitHub
parent 043beca616
commit 86b5f108d0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 40 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
src/lib/features/scheduler/scheduler-service.test.ts
View File

@ -176,10 +176,15 @@ test('Can handle crash of a async job', async () => {
await ms(75);
schedulerService.stop();
expect(getRecords()).toEqual([
['initial scheduled job failed | id: test-id-10 | async reason'],
['interval scheduled job failed | id: test-id-10 | async reason'],
]);
const records = getRecords();
expect(records[0][0]).toContain(
'initial scheduled job failed | id: test-id-10',
);
expect(records[0][1]).toContain('async reason');
expect(records[1][0]).toContain(
'interval scheduled job failed | id: test-id-10',
);
expect(records[1][1]).toContain('async reason');
});
test('Can handle crash of a sync job', async () => {
@ -196,30 +201,14 @@ test('Can handle crash of a sync job', async () => {
await ms(75);
schedulerService.stop();
expect(getRecords()).toEqual([
['initial scheduled job failed | id: test-id-11 | Error: sync reason'],
['interval scheduled job failed | id: test-id-11 | Error: sync reason'],
]);
});
test('Can handle crash of a async job', async () => {
const { logger, getRecords } = getLogger();
const { schedulerService } = createSchedulerTestService({
loggerOverride: logger,
});
const job = async () => {
await Promise.reject('async reason');
};
await schedulerService.schedule(job, 50, 'test-id-10');
await ms(75);
schedulerService.stop();
expect(getRecords()).toEqual([
['initial scheduled job failed | id: test-id-10 | async reason'],
['interval scheduled job failed | id: test-id-10 | async reason'],
]);
const records = getRecords();
expect(records[0][0]).toContain(
'initial scheduled job failed | id: test-id-11',
);
expect(records[0][1].message).toContain('sync reason');
expect(records[1][0]).toContain(
'interval scheduled job failed | id: test-id-11',
);
});
it('should emit scheduler job time event when scheduled function is run', async () => {

7
src/lib/features/scheduler/scheduler-service.ts
View File

@ -52,7 +52,8 @@ export class SchedulerService {
}
} catch (e) {
this.logger.error(
`interval scheduled job failed | id: ${id} | ${e}`,
`interval scheduled job failed | id: ${id}`,
e,
);
}
}, timeMs).unref(),
@ -64,9 +65,7 @@ export class SchedulerService {
await runScheduledFunctionWithEvent();
}
} catch (e) {
this.logger.error(
`initial scheduled job failed | id: ${id} | ${e}`,
);
this.logger.error(`initial scheduled job failed | id: ${id}`, e);
}
}

8
src/lib/metrics.ts
View File

@ -456,10 +456,14 @@ export default class MetricsMonitor {
},
);
eventStore.on(FEATURE_ARCHIVED, ({ featureName, project }) => {
featureToggleUpdateTotal.labels(featureName, project, 'n/a').inc();
featureToggleUpdateTotal
.labels(featureName, project, 'n/a', 'n/a')
.inc();
});
eventStore.on(FEATURE_REVIVED, ({ featureName, project }) => {
featureToggleUpdateTotal.labels(featureName, project, 'n/a').inc();
featureToggleUpdateTotal
.labels(featureName, project, 'n/a', 'n/a')
.inc();
});
eventBus.on(CLIENT_METRICS, (m: ValidatedClientMetrics) => {

22
src/lib/services/scheduler-service.test.ts
View File

@ -100,10 +100,13 @@ test('Can handle crash of a async job', async () => {
await ms(75);
schedulerService.stop();
expect(getRecords()).toEqual([
['initial scheduled job failed | id: test-id-10 | async reason'],
['interval scheduled job failed | id: test-id-10 | async reason'],
]);
const records = getRecords();
expect(records[0][0]).toContain(
'initial scheduled job failed | id: test-id-10',
);
expect(records[1][0]).toContain(
'interval scheduled job failed | id: test-id-10',
);
});
test('Can handle crash of a sync job', async () => {
@ -115,8 +118,11 @@ test('Can handle crash of a sync job', async () => {
await ms(75);
schedulerService.stop();
expect(getRecords()).toEqual([
['initial scheduled job failed | id: test-id-11 | Error: sync reason'],
['interval scheduled job failed | id: test-id-11 | Error: sync reason'],
]);
const records = getRecords();
expect(records[0][0]).toContain(
'initial scheduled job failed | id: test-id-11',
);
expect(records[1][0]).toContain(
'interval scheduled job failed | id: test-id-11',
);
});