Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-04 00:18:01 +01:00
Code Issues Projects Releases Wiki Activity

fix: strategyId in edit strategy API command endpoint (#3725)

Browse Source 
Fixes a small issue where the "API Command" for edit strategy was
showing the strategyId as `undefined`:


`/api/admin/projects/demo-app/features/demoApp.step1/environments/dev/strategies/undefined'`


![image](https://github.com/Unleash/unleash/assets/14320932/19650a15-5cde-43c3-9d2b-a7e790bea0ac)
This commit is contained in:
Nuno Góis 2023-05-09 14:39:28 +01:00 committed by GitHub
parent 72eba37cec
commit 8746cb1f89
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
frontend/src/component/feature/FeatureStrategy/FeatureStrategyEdit/FeatureStrategyEdit.test.tsx
View File

@ -31,12 +31,13 @@ test('formatUpdateStrategyApiCode', () => {
'projectId', 'projectId',
'featureId', 'featureId',
'environmentId', 'environmentId',
'strategyId',
strategy, strategy,
strategyDefinition, strategyDefinition,
'unleashUrl' 'unleashUrl'
) )
).toMatchInlineSnapshot(` ).toMatchInlineSnapshot(`
"curl --location --request PUT 'unleashUrl/api/admin/projects/projectId/features/featureId/environments/environmentId/strategies/a' \\\\ "curl --location --request PUT 'unleashUrl/api/admin/projects/projectId/features/featureId/environments/environmentId/strategies/strategyId' \\\\
--header 'Authorization: INSERT_API_KEY' \\\\ --header 'Authorization: INSERT_API_KEY' \\\\
--header 'Content-Type: application/json' \\\\ --header 'Content-Type: application/json' \\\\
--data-raw '{ --data-raw '{

4
frontend/src/component/feature/FeatureStrategy/FeatureStrategyEdit/FeatureStrategyEdit.tsx
View File

@ -213,6 +213,7 @@ export const FeatureStrategyEdit = () => {
projectId, projectId,
featureId, featureId,
environmentId, environmentId,
strategyId,
payload, payload,
strategyDefinition, strategyDefinition,
unleashUrl unleashUrl
@ -272,6 +273,7 @@ export const formatUpdateStrategyApiCode = (
projectId: string, projectId: string,
featureId: string, featureId: string,
environmentId: string, environmentId: string,
strategyId: string,
strategy: Partial<IFeatureStrategy>, strategy: Partial<IFeatureStrategy>,
strategyDefinition: IStrategy, strategyDefinition: IStrategy,
unleashUrl?: string unleashUrl?: string
@ -290,7 +292,7 @@ export const formatUpdateStrategyApiCode = (
), ),
}; };
const url = `${unleashUrl}/api/admin/projects/${projectId}/features/${featureId}/environments/${environmentId}/strategies/${strategy.id}`; const url = `${unleashUrl}/api/admin/projects/${projectId}/features/${featureId}/environments/${environmentId}/strategies/${strategyId}`;
const payload = JSON.stringify(sortedStrategy, undefined, 2); const payload = JSON.stringify(sortedStrategy, undefined, 2);
return `curl --location --request PUT '${url}' \\ return `curl --location --request PUT '${url}' \\