From 898c1b4bc76371b3891a654439cad0b395a0ede1 Mon Sep 17 00:00:00 2001 From: Fredrik Strand Oseberg Date: Tue, 24 Oct 2023 17:26:18 +0200 Subject: [PATCH] fix: only get rows for toggles in project (#5141) --- .../feature-toggle-strategies-store.ts | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/lib/features/feature-toggle/feature-toggle-strategies-store.ts b/src/lib/features/feature-toggle/feature-toggle-strategies-store.ts index e1628fea94..ab5e3fcc2a 100644 --- a/src/lib/features/feature-toggle/feature-toggle-strategies-store.ts +++ b/src/lib/features/feature-toggle/feature-toggle-strategies-store.ts @@ -551,11 +551,17 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore { .leftJoin('feature_tag as ft', 'ft.feature_name', 'features.name'); if (this.flagResolver.isEnabled('useLastSeenRefactor')) { - query.leftJoin( - 'last_seen_at_metrics', - 'last_seen_at_metrics.environment', - 'environments.name', - ); + query.leftJoin('last_seen_at_metrics', function () { + this.on( + 'last_seen_at_metrics.environment', + '=', + 'environments.name', + ).andOn( + 'last_seen_at_metrics.feature_name', + '=', + 'features.name', + ); + }); } let selectColumns = [ @@ -615,7 +621,6 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore { query = query.select(selectColumns); const rows = await query; - if (rows.length > 0) { const overview = this.getFeatureOverviewData(getUniqueRows(rows)); return sortEnvironments(overview);