From 89df3f364ead1f322cb033686deb97f12b22d806 Mon Sep 17 00:00:00 2001
From: andreas-unleash <andreas@getunleash.ai>
Date: Fri, 26 May 2023 17:42:42 +0300
Subject: [PATCH] Fix: laggy toggles (#3873)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This PR removes the `disabled` state for the feature toggle env
switches.

This is what causes the lag from when you toggle the switch to when it
becomes available for actions again.


Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Co-authored-by: Nuno Góis <github@nunogois.com>
---
 .../FeatureToggleSwitch.tsx                   | 21 +++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/frontend/src/component/project/Project/ProjectFeatureToggles/FeatureToggleSwitch/FeatureToggleSwitch.tsx b/frontend/src/component/project/Project/ProjectFeatureToggles/FeatureToggleSwitch/FeatureToggleSwitch.tsx
index 12d85cee74..d5c804d19c 100644
--- a/frontend/src/component/project/Project/ProjectFeatureToggles/FeatureToggleSwitch/FeatureToggleSwitch.tsx
+++ b/frontend/src/component/project/Project/ProjectFeatureToggles/FeatureToggleSwitch/FeatureToggleSwitch.tsx
@@ -134,13 +134,13 @@ export const FeatureToggleSwitch: VFC<IFeatureToggleSwitchProps> = ({
                 onChangeRequestToggle(
                     feature.name,
                     environmentName,
-                    !value,
+                    !isChecked,
                     false
                 );
             }
             return;
         }
-        if (value) {
+        if (isChecked) {
             await handleToggleEnvironmentOff();
             return;
         }
@@ -159,7 +159,12 @@ export const FeatureToggleSwitch: VFC<IFeatureToggleSwitchProps> = ({
             },
         });
         if (isChangeRequestConfigured(environmentName)) {
-            onChangeRequestToggle(feature.name, environmentName, !value, true);
+            onChangeRequestToggle(
+                feature.name,
+                environmentName,
+                !isChecked,
+                true
+            );
         } else {
             await handleToggleEnvironmentOn(true);
         }
@@ -173,7 +178,12 @@ export const FeatureToggleSwitch: VFC<IFeatureToggleSwitchProps> = ({
             },
         });
         if (isChangeRequestConfigured(environmentName)) {
-            onChangeRequestToggle(feature.name, environmentName, !value, false);
+            onChangeRequestToggle(
+                feature.name,
+                environmentName,
+                !isChecked,
+                false
+            );
         } else {
             await handleToggleEnvironmentOn();
         }
@@ -201,7 +211,7 @@ export const FeatureToggleSwitch: VFC<IFeatureToggleSwitchProps> = ({
             >
                 <PermissionSwitch
                     tooltip={
-                        value
+                        isChecked
                             ? `Disable feature in ${environmentName}`
                             : `Enable feature in ${environmentName}`
                     }
@@ -211,7 +221,6 @@ export const FeatureToggleSwitch: VFC<IFeatureToggleSwitchProps> = ({
                     permission={UPDATE_FEATURE_ENVIRONMENT}
                     inputProps={{ 'aria-label': environmentName }}
                     onClick={onClick}
-                    disabled={isChecked !== value}
                 />
             </StyledBoxContainer>
             {showStrategyImprovements && (