From 89f63285a00543402e3add1c5a2c12a11c4aa39d Mon Sep 17 00:00:00 2001 From: Thomas Heartman Date: Mon, 31 Mar 2025 15:59:09 +0200 Subject: [PATCH] Fix: Move hooks to before we bail if the flag is off. (#9659) This fixes the a react crash when we render more/fewer hooks than on the previous render if the flag state changes. --- .../FeatureView/FeatureOverview/FeatureOverview.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverview.tsx b/frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverview.tsx index ca53e1fdda..964162878f 100644 --- a/frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverview.tsx +++ b/frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverview.tsx @@ -49,17 +49,17 @@ export const FeatureOverview = () => { setLastViewed({ featureId, projectId }); }, [featureId]); const flagOverviewRedesign = useUiFlag('flagOverviewRedesign'); + const { setSplashSeen } = useSplashApi(); + const { splash } = useAuthSplash(); + const [showTooltip, setShowTooltip] = useState(false); + const [hasClosedTooltip, setHasClosedTooltip] = useState(false); if (!flagOverviewRedesign) { return ; } - const { setSplashSeen } = useSplashApi(); - const { splash } = useAuthSplash(); const dragTooltipSplashId = 'strategy-drag-tooltip'; const shouldShowStrategyDragTooltip = !splash?.[dragTooltipSplashId]; - const [showTooltip, setShowTooltip] = useState(false); - const [hasClosedTooltip, setHasClosedTooltip] = useState(false); const toggleShowTooltip = (envIsOpen: boolean) => { setShowTooltip( !hasClosedTooltip && shouldShowStrategyDragTooltip && envIsOpen,