Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-01 00:08:27 +01:00
Code Issues Projects Releases Wiki Activity

fix list logic typ0

Browse Source
This commit is contained in:
sveisvei 2016-11-07 08:44:46 +01:00
parent e5c3495463
commit 8bbbc5b470
3 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/unleash-api/lib/client-metrics/list.js
View File

@ -11,6 +11,7 @@ class Node {
link (next) { link (next) {
this.next = next; this.next = next;
next.prev = this; next.prev = this;
return this;
} }
} }
@ -30,9 +31,8 @@ module.exports = class List extends EventEmitter {
add (obj) { add (obj) {
const node = new Node(obj); const node = new Node(obj);
if (this.tail) { if (this.start) {
this.tail.link(node); this.start = node.link(this.start);
this.tail = node;
} else { } else {
this.start = node; this.start = node;
this.tail = node; this.tail = node;

6
packages/unleash-api/lib/client-metrics/list.test.js
View File

@ -51,10 +51,10 @@ test('list should be able remove until given value', (t) => {
list.reverseRemoveUntilTrue(({ value }) => value === 4); list.reverseRemoveUntilTrue(({ value }) => value === 4);
t.true(list.toArray().length === 4); t.true(list.toArray().length === 4);
list.reverseRemoveUntilTrue(({ value }) => value === 3); list.reverseRemoveUntilTrue(({ value }) => value === 5);
t.true(list.toArray().length === 3); t.true(list.toArray().length === 3);
list.reverseRemoveUntilTrue(({ value }) => value === 3); list.reverseRemoveUntilTrue(({ value }) => value === 5);
t.true(list.toArray().length === 3); t.true(list.toArray().length === 3);
}); });
@ -98,7 +98,7 @@ test('should reverse iterate', (t) => {
let iterateCount = 0; let iterateCount = 0;
list.iterateReverse(({ value }) => { list.iterateReverse(({ value }) => {
iterateCount++; iterateCount++;
if (value === 3) { if (value === 5) {
return false; return false;
} }
return true; return true;

9
packages/unleash-api/lib/client-metrics/ttl-list.test.js
View File

@ -28,16 +28,13 @@ test.cb('should slice off list', (t) => {
}); });
// console.time('4'); // console.time('4');
list.add({ n: '4' }, moment().add(300, 'milliseconds'));
// console.time('3'); // console.time('3');
list.add({ n: '3' }, moment().add(200, 'milliseconds'));
// console.time('2'); // console.time('2');
list.add({ n: '2' }, moment().add(50, 'milliseconds'));
// console.time('1'); // console.time('1');
list.add({ n: '1' }, moment().add(1, 'milliseconds')); list.add({ n: '1' }, moment().add(1, 'milliseconds'));
list.add({ n: '2' }, moment().add(50, 'milliseconds'));
list.add({ n: '3' }, moment().add(200, 'milliseconds'));
list.add({ n: '4' }, moment().add(300, 'milliseconds'));
const expired = []; const expired = [];