Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-10 17:53:36 +02:00
Code Issues Projects Releases Wiki Activity

[Gitar] Cleaning up stale feature flag: stripClientHeadersOn304 with value true (#6868)

Browse Source 
<details>
  <summary>Feature Flag Cleanup</summary>

  | Stale Flag |  Value  |
  | ---------- | ------- |
  |   stripClientHeadersOn304   | true |

  </details>

  <details>
  <summary>Trigger</summary>

  https://github.com/Unleash/unleash/issues/6559#issuecomment-2058848984

  </details>

  <details>
  <summary>Bot Commands</summary>

`@gitar-bot cleanup stale_flag=value` will cleanup a stale feature flag.
Replace `stale_flag` with the name of the stale feature flag and `value`
with either `true` or `false`.

  </details>

---------

Co-authored-by: Gitar Bot <noreply@gitar.co>
This commit is contained in:
gitar-bot[bot] 2024-04-16 13:42:31 +02:00 committed by GitHub
parent 279d3431eb
commit 8dbd680326
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 4 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/lib/__snapshots__/create-config.test.ts.snap
View File

@ -144,7 +144,6 @@ exports[`should create default config 1`] = `
"showInactiveUsers": false, "showInactiveUsers": false,
"signals": false, "signals": false,
"strictSchemaValidation": false, "strictSchemaValidation": false,
"stripClientHeadersOn304": false,
"useMemoizedActiveTokens": false, "useMemoizedActiveTokens": false,
"userAccessUIEnabled": false, "userAccessUIEnabled": false,
"variantDependencies": false, "variantDependencies": false,

6
src/lib/features/client-feature-toggles/client-feature-toggle.controller.ts
View File

@ -241,11 +241,7 @@ export default class FeatureController extends Controller {
if (etag === userVersion) { if (etag === userVersion) {
res.status(304); res.status(304);
if (this.flagResolver.isEnabled('stripClientHeadersOn304')) { res.getHeaderNames().forEach((header) => res.removeHeader(header));
res.getHeaderNames().forEach((header) =>
res.removeHeader(header),
);
}
res.end(); res.end();
return; return;
} else { } else {

8
src/lib/features/metrics/instance/metrics.ts
View File

@ -120,11 +120,9 @@ export default class ClientMetricsController extends Controller {
); );
await this.metricsV2.registerClientMetrics(data, clientIp); await this.metricsV2.registerClientMetrics(data, clientIp);
if (this.flagResolver.isEnabled('stripClientHeadersOn304')) { res.getHeaderNames().forEach((header) =>
res.getHeaderNames().forEach((header) => res.removeHeader(header),
res.removeHeader(header), );
);
}
res.status(202).end(); res.status(202).end();
} catch (e) { } catch (e) {
res.status(400).end(); res.status(400).end();

6
src/lib/types/experimental.ts
View File

@ -25,7 +25,6 @@ export type IFlagKey =
| 'advancedPlayground' | 'advancedPlayground'
| 'filterInvalidClientMetrics' | 'filterInvalidClientMetrics'
| 'disableMetrics' | 'disableMetrics'
| 'stripClientHeadersOn304'
| 'stripHeadersOnAPI' | 'stripHeadersOnAPI'
| 'signals' | 'signals'
| 'automatedActions' | 'automatedActions'
@ -133,11 +132,6 @@ const flags: IFlags = {
process.env.UNLEASH_EXPERIMENTAL_DISABLE_METRICS, process.env.UNLEASH_EXPERIMENTAL_DISABLE_METRICS,
false, false,
), ),
stripClientHeadersOn304: parseEnvVarBoolean(
process.env
.UNLEASH_EXPERIMENTAL_DETECT_SEGMENT_USAGE_IN_CHANGE_REQUESTS,
false,
),
signals: parseEnvVarBoolean( signals: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_SIGNALS, process.env.UNLEASH_EXPERIMENTAL_SIGNALS,
false, false,

1
src/server-dev.ts
View File

@ -40,7 +40,6 @@ process.nextTick(async () => {
embedProxyFrontend: true, embedProxyFrontend: true,
anonymiseEventLog: false, anonymiseEventLog: false,
responseTimeWithAppNameKillSwitch: false, responseTimeWithAppNameKillSwitch: false,
stripClientHeadersOn304: true,
stripHeadersOnAPI: true, stripHeadersOnAPI: true,
celebrateUnleash: true, celebrateUnleash: true,
featureSearchFeedbackPosting: true, featureSearchFeedbackPosting: true,