Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-19 00:15:43 +01:00
Code Issues Projects Releases Wiki Activity

task: make setting service handle conflict on insert (#9160)

Browse Source 
Currently, in enterprise we're struggling with setting service and
transactionality; all our verfications says that the setting key is not
present, so setting-store happily tries to insert a new row with a new
PK. However, somehow at the same time, the key already exists. This
commit adds conflict handling to the insertNewRow.
This commit is contained in:
Christopher Kolstad 2025-02-13 15:54:43 +01:00 committed by GitHub
parent 1036fb6012
commit 8de801025f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/lib/db/setting-store.ts
View File

@ -32,10 +32,6 @@ export default class SettingStore implements ISettingStore {
}); });
} }
async insertNewRow(name: string, content: any) {
return this.db(TABLE).insert({ name, content });
}
async exists(name: string): Promise<boolean> { async exists(name: string): Promise<boolean> {
const result = await this.db.raw( const result = await this.db.raw(
`SELECT EXISTS (SELECT 1 FROM ${TABLE} WHERE name = ?) AS present`, `SELECT EXISTS (SELECT 1 FROM ${TABLE} WHERE name = ?) AS present`,
@ -58,13 +54,12 @@ export default class SettingStore implements ISettingStore {
return undefined; return undefined;
} }
// Is actually an upsert
async insert(name: string, content: any): Promise<void> { async insert(name: string, content: any): Promise<void> {
const exists = await this.exists(name); await this.db(TABLE)
if (exists) { .insert({ name, content })
await this.updateRow(name, content); .onConflict('name')
} else { .merge();
await this.insertNewRow(name, content);
}
} }
async delete(name: string): Promise<void> { async delete(name: string): Promise<void> {