From 8e3e973f2295a1000bb4186bacef309e4394272d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ivar=20Conradi=20=C3=98sthus?= Date: Tue, 8 Jun 2021 20:15:03 +0200 Subject: [PATCH] fix: make sure routes/user handles api calls --- src/lib/routes/admin-api/user.ts | 2 +- src/lib/services/user-feedback-service.ts | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/lib/routes/admin-api/user.ts b/src/lib/routes/admin-api/user.ts index 5c8642044d..b8c9e4655d 100644 --- a/src/lib/routes/admin-api/user.ts +++ b/src/lib/routes/admin-api/user.ts @@ -69,7 +69,7 @@ class UserController extends Controller { user, ); const feedback = await this.userFeedbackService.getAllUserFeedback( - user.id, + user, ); delete user.permissions; // TODO: remove diff --git a/src/lib/services/user-feedback-service.ts b/src/lib/services/user-feedback-service.ts index 4e5d69e6ab..f3325d623d 100644 --- a/src/lib/services/user-feedback-service.ts +++ b/src/lib/services/user-feedback-service.ts @@ -2,6 +2,7 @@ import { Logger } from '../logger'; import UserFeedbackStore, { IUserFeedback } from '../db/user-feedback-store'; import { IUnleashStores } from '../types/stores'; import { IUnleashConfig } from '../types/option'; +import User from '../types/user'; export default class UserFeedbackService { private userFeedbackStore: UserFeedbackStore; @@ -16,8 +17,11 @@ export default class UserFeedbackService { this.logger = getLogger('services/user-feedback-service.js'); } - async getAllUserFeedback(user_id: number): Promise { - return this.userFeedbackStore.getAllUserFeedback(user_id); + async getAllUserFeedback(user: User): Promise { + if (user.isAPI) { + return []; + } + return this.userFeedbackStore.getAllUserFeedback(user.id); } async getFeedback(