From 8fae8fb8b359b9c8d0dbef1508d8be58de8fe32b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nuno=20G=C3=B3is?= <github@nunogois.com>
Date: Fri, 16 May 2025 15:06:53 +0100
Subject: [PATCH] chore: remove teams integration CR events flag (#10015)

https://linear.app/unleash/issue/2-3265/investigate-teams-integration-for-change-request-notifications

Removes the `teamsIntegrationChangeRequests` feature flag.

Follow-up to: https://github.com/Unleash/unleash/pull/9309
---
 src/lib/addons/teams-definition.ts | 30 +++++++++++++++++++++++
 src/lib/addons/teams.ts            | 38 ------------------------------
 src/lib/types/experimental.ts      |  5 ----
 src/server-dev.ts                  |  1 -
 4 files changed, 30 insertions(+), 44 deletions(-)

diff --git a/src/lib/addons/teams-definition.ts b/src/lib/addons/teams-definition.ts
index d3b5d2ff90..54f7f9f489 100644
--- a/src/lib/addons/teams-definition.ts
+++ b/src/lib/addons/teams-definition.ts
@@ -14,6 +14,21 @@ import {
     FEATURE_PROJECT_CHANGE,
     FEATURE_VARIANTS_UPDATED,
     FEATURE_POTENTIALLY_STALE_ON,
+    CHANGE_ADDED,
+    CHANGE_DISCARDED,
+    CHANGE_EDITED,
+    CHANGE_REQUEST_APPLIED,
+    CHANGE_REQUEST_APPROVAL_ADDED,
+    CHANGE_REQUEST_APPROVED,
+    CHANGE_REQUEST_CANCELLED,
+    CHANGE_REQUEST_CREATED,
+    CHANGE_REQUEST_DISCARDED,
+    CHANGE_REQUEST_REJECTED,
+    CHANGE_REQUEST_SENT_TO_REVIEW,
+    CHANGE_REQUEST_SCHEDULED,
+    CHANGE_REQUEST_SCHEDULED_APPLICATION_SUCCESS,
+    CHANGE_REQUEST_SCHEDULED_APPLICATION_FAILURE,
+    CHANGE_REQUEST_SCHEDULE_SUSPENDED,
 } from '../events/index.js';
 import type { IAddonDefinition } from '../types/model.js';
 
@@ -61,6 +76,21 @@ const teamsDefinition: IAddonDefinition = {
         FEATURE_VARIANTS_UPDATED,
         FEATURE_PROJECT_CHANGE,
         FEATURE_POTENTIALLY_STALE_ON,
+        CHANGE_ADDED,
+        CHANGE_DISCARDED,
+        CHANGE_EDITED,
+        CHANGE_REQUEST_APPLIED,
+        CHANGE_REQUEST_APPROVAL_ADDED,
+        CHANGE_REQUEST_APPROVED,
+        CHANGE_REQUEST_CANCELLED,
+        CHANGE_REQUEST_CREATED,
+        CHANGE_REQUEST_DISCARDED,
+        CHANGE_REQUEST_REJECTED,
+        CHANGE_REQUEST_SENT_TO_REVIEW,
+        CHANGE_REQUEST_SCHEDULED,
+        CHANGE_REQUEST_SCHEDULED_APPLICATION_SUCCESS,
+        CHANGE_REQUEST_SCHEDULED_APPLICATION_FAILURE,
+        CHANGE_REQUEST_SCHEDULE_SUSPENDED,
     ],
 };
 
diff --git a/src/lib/addons/teams.ts b/src/lib/addons/teams.ts
index 00d4c6d4c7..cc44b9ec45 100644
--- a/src/lib/addons/teams.ts
+++ b/src/lib/addons/teams.ts
@@ -13,24 +13,6 @@ import {
 import type { IEvent } from '../events/index.js';
 import type { IntegrationEventState } from '../features/integration-events/integration-events-store.js';
 
-import {
-    CHANGE_ADDED,
-    CHANGE_DISCARDED,
-    CHANGE_EDITED,
-    CHANGE_REQUEST_APPLIED,
-    CHANGE_REQUEST_APPROVAL_ADDED,
-    CHANGE_REQUEST_APPROVED,
-    CHANGE_REQUEST_CANCELLED,
-    CHANGE_REQUEST_CREATED,
-    CHANGE_REQUEST_DISCARDED,
-    CHANGE_REQUEST_REJECTED,
-    CHANGE_REQUEST_SENT_TO_REVIEW,
-    CHANGE_REQUEST_SCHEDULED,
-    CHANGE_REQUEST_SCHEDULED_APPLICATION_SUCCESS,
-    CHANGE_REQUEST_SCHEDULED_APPLICATION_FAILURE,
-    CHANGE_REQUEST_SCHEDULE_SUSPENDED,
-} from '../events/index.js';
-
 interface ITeamsParameters {
     url: string;
     customHeaders?: string;
@@ -41,26 +23,6 @@ export default class TeamsAddon extends Addon {
     declare flagResolver: IFlagResolver;
 
     constructor(args: IAddonConfig) {
-        if (args.flagResolver.isEnabled('teamsIntegrationChangeRequests')) {
-            teamsDefinition.events = [
-                ...teamsDefinition.events!,
-                CHANGE_ADDED,
-                CHANGE_DISCARDED,
-                CHANGE_EDITED,
-                CHANGE_REQUEST_APPLIED,
-                CHANGE_REQUEST_APPROVAL_ADDED,
-                CHANGE_REQUEST_APPROVED,
-                CHANGE_REQUEST_CANCELLED,
-                CHANGE_REQUEST_CREATED,
-                CHANGE_REQUEST_DISCARDED,
-                CHANGE_REQUEST_REJECTED,
-                CHANGE_REQUEST_SENT_TO_REVIEW,
-                CHANGE_REQUEST_SCHEDULED,
-                CHANGE_REQUEST_SCHEDULED_APPLICATION_SUCCESS,
-                CHANGE_REQUEST_SCHEDULED_APPLICATION_FAILURE,
-                CHANGE_REQUEST_SCHEDULE_SUSPENDED,
-            ];
-        }
         super(teamsDefinition, args);
         this.msgFormatter = new FeatureEventFormatterMd({
             unleashUrl: args.unleashUrl,
diff --git a/src/lib/types/experimental.ts b/src/lib/types/experimental.ts
index 42518e8e18..c46321c036 100644
--- a/src/lib/types/experimental.ts
+++ b/src/lib/types/experimental.ts
@@ -55,7 +55,6 @@ export type IFlagKey =
     | 'deltaApi'
     | 'uniqueSdkTracking'
     | 'consumptionModel'
-    | 'teamsIntegrationChangeRequests'
     | 'edgeObservability'
     | 'addEditStrategy'
     | 'cleanupReminder'
@@ -266,10 +265,6 @@ const flags: IFlags = {
         process.env.EXPERIMENTAL_CONSUMPTION_MODEL,
         false,
     ),
-    teamsIntegrationChangeRequests: parseEnvVarBoolean(
-        process.env.EXPERIMENTAL_TEAMS_INTEGRATION_CHANGE_REQUESTS,
-        false,
-    ),
     edgeObservability: parseEnvVarBoolean(
         process.env.EXPERIMENTAL_EDGE_OBSERVABILITY,
         false,
diff --git a/src/server-dev.ts b/src/server-dev.ts
index ff7555f542..f6b5f3c3a2 100644
--- a/src/server-dev.ts
+++ b/src/server-dev.ts
@@ -50,7 +50,6 @@ process.nextTick(async () => {
                         showUserDeviceCount: true,
                         deltaApi: true,
                         uniqueSdkTracking: true,
-                        teamsIntegrationChangeRequests: true,
                         addEditStrategy: true,
                         cleanupReminder: true,
                         strictSchemaValidation: true,