Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-06-14 01:16:17 +02:00
Code Issues Projects Releases Wiki Activity

fix: remove uneccesary code (#2417)

Browse Source 
* Removes dead code from the ProjectOverview.tsx component
This commit is contained in:
Fredrik Strand Oseberg 2022-11-14 12:54:41 +01:00 committed by GitHub
parent 4689705f45
commit 900c50b8c8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 125 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
frontend/src/component/project/Project/Project.tsx
View File

@ -213,17 +213,7 @@ const Project = () => {
</StyledDiv> </StyledDiv>
</h2> </h2>
</div> </div>
<ConditionallyRender
condition={error}
show={
<ApiError
data-loading
style={{ maxWidth: '400px', margin: '1rem' }}
onClick={refetch}
text="Could not fetch project"
/>
}
/>
<div className={styles.separator} /> <div className={styles.separator} />
<div className={styles.tabContainer}> <div className={styles.tabContainer}>
<Tabs <Tabs

23
frontend/src/component/project/Project/ProjectInfo/ProjectInfo.styles.ts
View File

@ -14,20 +14,6 @@ export const useStyles = makeStyles()(theme => ({
marginBottom: '1rem', marginBottom: '1rem',
}, },
}, },
description: {
textAlign: 'left',
marginBottom: '0.5rem',
},
descriptionContainer: {
display: 'flex',
justifyContent: 'space-between',
},
idContainer: {
display: 'flex',
width: '100%',
textAlign: 'left',
wordBreak: 'break-all',
},
percentageContainer: { percentageContainer: {
display: 'flex', display: 'flex',
justifyContent: 'center', justifyContent: 'center',
@ -91,15 +77,6 @@ export const useStyles = makeStyles()(theme => ({
bottom: '5px', bottom: '5px',
}, },
}, },
accordion: {
boxShadow: 'none',
textAlign: 'left',
},
accordionBody: { padding: '0', wordBreak: 'break-all' },
accordionActions: {
padding: '0',
justifyContent: 'flex-start',
},
linkText: { linkText: {
[theme.breakpoints.down('md')]: { [theme.breakpoints.down('md')]: {
display: 'none', display: 'none',

93
frontend/src/component/project/Project/ProjectInfo/ProjectInfo.tsx
View File

@ -2,20 +2,12 @@ import { useStyles } from './ProjectInfo.styles';
import { Link } from 'react-router-dom'; import { Link } from 'react-router-dom';
import ArrowForwardIcon from '@mui/icons-material/ArrowForward'; import ArrowForwardIcon from '@mui/icons-material/ArrowForward';
import classnames from 'classnames'; import classnames from 'classnames';
import { Edit, ExpandMore } from '@mui/icons-material';
import { useThemeStyles } from 'themes/themeStyles'; import { useThemeStyles } from 'themes/themeStyles';
import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig'; import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig';
import PercentageCircle from 'component/common/PercentageCircle/PercentageCircle'; import PercentageCircle from 'component/common/PercentageCircle/PercentageCircle';
import PermissionIconButton from 'component/common/PermissionIconButton/PermissionIconButton';
import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender'; import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
import {
Accordion,
AccordionActions,
AccordionDetails,
AccordionSummary,
} from '@mui/material';
import { UPDATE_PROJECT } from 'component/providers/AccessProvider/permissions';
import { DEFAULT_PROJECT_ID } from '../../../../hooks/api/getters/useDefaultProject/useDefaultProjectId'; import { DEFAULT_PROJECT_ID } from '../../../../hooks/api/getters/useDefaultProject/useDefaultProjectId';
interface IProjectInfoProps { interface IProjectInfoProps {
@ -34,7 +26,7 @@ const ProjectInfo = ({
}: IProjectInfoProps) => { }: IProjectInfoProps) => {
const { classes: themeStyles } = useThemeStyles(); const { classes: themeStyles } = useThemeStyles();
const { classes: styles } = useStyles(); const { classes: styles } = useStyles();
const { uiConfig, isOss } = useUiConfig(); const { uiConfig } = useUiConfig();
let link = `/admin/users`; let link = `/admin/users`;
@ -42,90 +34,9 @@ const ProjectInfo = ({
link = `/projects/${id}/access`; link = `/projects/${id}/access`;
} }
const LONG_DESCRIPTION = 100;
const isShortDescription =
!description || description.length < LONG_DESCRIPTION;
const permissionButtonClass = classnames({
[styles.permissionButtonShortDesc]: isShortDescription,
});
const permissionButton = (
<div>
<PermissionIconButton
permission={UPDATE_PROJECT}
hidden={isOss()}
projectId={id}
component={Link}
className={permissionButtonClass}
data-loading
to={`/projects/${id}/edit`}
tooltipProps={{ title: 'Edit description' }}
>
<Edit />
</PermissionIconButton>
</div>
);
return ( return (
<aside> <aside>
<div className={styles.projectInfo}> <div className={styles.projectInfo}>
<div className={styles.infoSection}>
<div className={styles.descriptionContainer}>
<ConditionallyRender
condition={Boolean(description)}
show={
<ConditionallyRender
condition={isShortDescription}
show={
<p
data-loading
className={styles.description}
>
{description}
</p>
}
elseShow={
<Accordion className={styles.accordion}>
<AccordionSummary
expandIcon={
<ExpandMore titleAccess="Toggle" />
}
className={styles.accordionBody}
>
Description
</AccordionSummary>
<AccordionDetails
className={styles.accordionBody}
>
{description}
</AccordionDetails>
<AccordionActions
className={
styles.accordionActions
}
>
Edit description{' '}
{permissionButton}
</AccordionActions>
</Accordion>
}
/>
}
elseShow={
<p data-loading className={styles.description}>
No description
</p>
}
/>
<ConditionallyRender
condition={isShortDescription}
show={permissionButton}
/>
</div>
<div className={styles.idContainer}>
<p>projectId: {id}</p>
</div>
</div>
<div className={styles.infoSection}> <div className={styles.infoSection}>
<div data-loading className={styles.percentageContainer}> <div data-loading className={styles.percentageContainer}>
<PercentageCircle percentage={health} /> <PercentageCircle percentage={health} />